+1 Peter
On Thu, Dec 26, 2013 at 1:17 PM, Jan Matèrne (jhm) <apa...@materne.de>wrote: > After investing some more time and doing a bootstrap build (thanks > Antoine): > > Running on Windows 7 64bit > Using Java 1.5 > C:\projekte\apache-ant\ANT_193>java -version > java version "1.5.0_22" > Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_22-b03) > Java HotSpot(TM) Client VM (build 1.5.0_22-b03, mixed mode) > Using empty environment variables for > JAVA_HOME > ANT_HOME > CLASSPATH > Path-Variable only points to JDK\bin > > Running "build dist test" > BUILD FAILED > C:\projekte\apache-ant\ANT_193\build.xml:1620: Unit tests failed; see: > C:\projekte\apache-ant\ANT_193\build\testcases\reports > C:\projekte\apache-ant\ANT_193\build\antunit\reports > > taskdef-antlib-test_xml > testAntlib > java.lang.IllegalStateException: zip file closed > at line 47 , column 69 > This test creates a jar containing an antlib definition with two > macros. > Loading that jar via <taskdef> throws this exception. > No idea here. > ==> not bad enough for me to vote against this release, because AntUnit > is loaded all the time, so taskdef works. > > ManifestClassPathTest > testDifferentWindowsDrive > Failure Should throw BuildException because: different drive > at > > org.apache.tools.ant.BuildFileTest.expectBuildExceptionContaining(BuildFileT > est.java:391) > at > > org.apache.tools.ant.taskdefs.ManifestClassPathTest.testDifferentWindowsDriv > e(ManifestClassPathTest.java:198) > This test runs only on Windows. > This test tries to get File.getCanonicalPath() of a file on a C: or D: > according to java.tmp.dir: > java.tmp.dir on C ? File(D:/foo.txt).getCanonicalPath() : > File(C:/foo.txt).getCanonicalPath() > Problem (on my machine): > D: exists but is not ready (CD-ROM with no CD inserted) > ==> not bad enough for me to vote against this release > > Running "apache-ant-1.9.3\bin\ant -f check.xml rat" > 11 Unknown Licenses > ******************************* > Unapproved licenses: > > > C:/projekte/apache-ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/Comman > dLauncherTask.java > > > C:/projekte/apache-ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > er/CommandLauncher.java > > > C:/projekte/apache-ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > er/CommandLauncherProxy.java > > > C:/projekte/apache-ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > er/Java13CommandLauncher.java > > > C:/projekte/apache-ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > er/MacCommandLauncher.java > > > C:/projekte/apache-ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > er/OS2CommandLauncher.java > > > C:/projekte/apache-ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > er/PerlScriptCommandLauncher.java > > > C:/projekte/apache-ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > er/ScriptCommandLauncher.java > > > C:/projekte/apache-ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > er/VmsCommandLauncher.java > > > C:/projekte/apache-ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > er/WinNTCommandLauncher.java > > > C:/projekte/apache-ant/ANT_193/src/main/org/apache/tools/ant/types/resources > /LazyResourceCollectionWrapper.java > > ==> I dont like the missing of the license header. But obviously we have > shipped that for more versions and its fixed now in trunk. > So ok with me. > > > So I could vote a +1. > > Jan > > > > > -----Ursprüngliche Nachricht----- > > Von: Jan Matèrne (jhm) [mailto:apa...@materne.de] > > Gesendet: Donnerstag, 26. Dezember 2013 15:41 > > An: 'Ant Developers List' > > Betreff: AW: [VOTE] Release Ant 1.9.3 > > > > Checked the tag http://svn.apache.org/repos/asf/ant/core/tags/ANT_193/ > > > > Using RAT (ant -f check.xml rat) > > > > 11 Unknown Licenses > > ******************************* > > Unapproved licenses: > > > > C:/projekte/apache- > > ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/Comman > > dLauncherTask.java > > > > C:/projekte/apache- > > ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > > er/CommandLauncher.java > > > > C:/projekte/apache- > > ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > > er/CommandLauncherProxy.java > > > > C:/projekte/apache- > > ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > > er/Java13CommandLauncher.java > > > > C:/projekte/apache- > > ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > > er/MacCommandLauncher.java > > > > C:/projekte/apache- > > ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > > er/OS2CommandLauncher.java > > > > C:/projekte/apache- > > ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > > er/PerlScriptCommandLauncher.java > > > > C:/projekte/apache- > > ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > > er/ScriptCommandLauncher.java > > > > C:/projekte/apache- > > ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > > er/VmsCommandLauncher.java > > > > C:/projekte/apache- > > ant/ANT_193/src/main/org/apache/tools/ant/taskdefs/launch > > er/WinNTCommandLauncher.java > > > > C:/projekte/apache- > > ant/ANT_193/src/main/org/apache/tools/ant/types/resources > > /LazyResourceCollectionWrapper.java > > > > > > > > Run the tests using Java 5 on Windows 7 64bit > > --------------------------------------------- > > java -version > > >java version "1.5.0_22" > > >Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_22-b03) > > >Java HotSpot(TM) Client VM (build 1.5.0_22-b03, mixed mode) > > > > AntUnit Test Results: 4 errors > > > > ant-attribute-test_xml : test-macrodef: Unknown attribute > > [ant:if:if:set] at line 70 , column 31 taskdef-antlib-test_xml : > > testAntlib: java.lang.IllegalStateException: zip file closed at line 47 > > , column 69 > > xslt-test_xml : testParameterTypes: Error param doesn't support > > the > > "type" attribute at line 46 , column 35 > > filterset-test_xml : testNestedPropertySet: Error filterset doesn't > > support the nested "propertyset" element. at line 82 , column 29 > > > > > > JUnit Test Results: 2 Failures, 5 Erros > > > > ManifestClassPathTest testDifferentWindowsDrive Failure Should > > throw > > BuildException because: different drive > > JspcTest testNoTld Failure Should throw BuildException because > > 'not found' with message containing 'Java returned: 9' (actual message > > 'Java > > returned: 1' instead) > > > > JspcTest testSimple Error Java returned: 1 > > JspcTest testUriroot Error Java returned: 1 > > JspcTest testXml Error Java returned: 1 > > JspcTest testKeyword Error Java returned: 1 > > JspcTest testInvalidClassname Error Java returned: 1 > > > > > > > > Haven't looked deeper into the failing tests. > > > > > > Jan > > > > > > > -----Ursprüngliche Nachricht----- > > > Von: Stefan Bodewig [mailto:bode...@apache.org] > > > Gesendet: Donnerstag, 26. Dezember 2013 07:49 > > > An: dev@ant.apache.org > > > Betreff: Re: [VOTE] Release Ant 1.9.3 > > > > > > On 2013-12-23, Antoine Levy Lambert wrote: > > > > > > > I propose to adopt the following as Ant 1.9.3 > > > > > > > SVN tag: http://svn.apache.org/repos/asf/ant/core/tags/ANT_193/ > > > > revision 1553123 > > > > Tarballs: https://dist.apache.org/repos/dist/dev/ant/ > > > > revision 3969 > > > > Maven Artifacts: > > > > > > > > https://repository.apache.org/content/repositories/orgapacheant- > > > 015/or > > > > g/apache/ant/ > > > > > > +1 > > > > > > Stefan > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional > > > commands, e-mail: dev-h...@ant.apache.org > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional > > commands, e-mail: dev-h...@ant.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > >
