On Tue, Feb 26, 2008 at 12:23 PM, Stefan Bodewig <[EMAIL PROTECTED]> wrote:
> As usual I lack the technological competence to vote on this part, so > I've again concentrated on checking the legal requirements and > infrastructire stuff. > > So far I didn't find any issues, which means I'm +1 on the release. > > The only stuff flagged by RAT are some JQuery files, the generated > package-list (I'll teach RAT to detect it as generated once the code > has moved into the incubator), the MANIFEST which cannot hold the > license info at the top and the *.patterns files. I'd probably add > licenses to the two .patterns files in the source distro just to be > complete (after the beta). > > A nit: since you don't distribute JSch in the source distribution you > wouldn't need to add its license to your LICENSE file, but I > understand that maintaining separate LICENSE files for bin-with-deps > and the other distributions would be a pain. > > Some questions (maybe I should kick of a new thread here, too late) > > Are the jars intended as the jars that go into the repository or do > you intend to distribute them via the normal download as well? Now that we provide Ivy jar in the maven repository, I think we could get rid of putting the jar in the distrib directory (which I've uploaded). So I think we can consider that the files intended to be distributed via the normal download are only zips, tar.gz and associated checksums/signatures, and that's all. The files which are intended to be distributed in the maven repository are available here: http://people.apache.org/~xavier/m2-staging-repo/org/apache/ivy/ivy/2.0.0-beta2/ I forgot to mention this in the vote. > > > The bin-with-deps distribution contains an ant-1.6.jar. Which x of > 1.6.x is this? Why not 1.7.0? Is this an unmodified version of Ant's > jar (I don't see the -launcher.jar)? It's this one: http://repo1.maven.org/maven2/ant/ant/1.6/ant-1.6.jar Since we have a dependency on Ant stated in our own ivy.xml, and since we use Ivy to manage our own dependencies, we end up with this jar in bin-with-deps distribution format. But I think we could exclude it, since it doesn't really make sense, people who want to use Ivy with Ant will install Ant themselves first. Should I make a new release for this, or can this wait for next release? > > > Is your MANIFEST.MF hand-crafted or created by something like bnd? I > ask because I think we should add OSGI information to Ant's jars as > well but am a bit undecided on how to go about it. It's hand-crafted. Colin Sampaleanu (Spring-DM lead) contributed the first version, we now maintain it by hand with the help of eclipse tooling. The only part being generated is the the Bundle-Version. Xavier > > > Stefan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- Xavier Hanin - Independent Java Consultant http://xhab.blogspot.com/ http://ant.apache.org/ivy/ http://www.xoocode.org/
