Re: svn commit: r580302 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java

[Alexey Solofnenko]

In general, I do not see a reason to replace perfectly readable single liners with several lines of code - it just increases code bloat. Anybody with high IQ should be able to read old code as is. In this case the change is warranted, but please move "is" variable and try/finally inside "else" - the scoping is wrong now.

- Alexey.

[EMAIL PROTECTED] wrote:

Author: peterreilly
Date: Fri Sep 28 04:13:19 2007
New Revision: 580302

URL: http://svn.apache.org/viewvc?rev=580302&view=rev
Log:
checkstyle: remove inner assignment

Modified:
    
ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java

Modified: 
ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java
URL: 
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java?rev=580302&r1=580301&r2=580302&view=diff
==============================================================================
--- 
ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java 
(original)
+++ 
ant/core/trunk/src/main/org/apache/tools/ant/types/resources/JavaResource.java 
Fri Sep 28 04:13:19 2007
@@ -130,8 +130,12 @@
     public boolean isExists() {
         InputStream is = null;
         try {
-            return isReference() ? ((Resource) getCheckedRef()).isExists()
-                : (is = getInputStream()) != null;
+            if (isReference()) {
+                return  ((Resource) getCheckedRef()).isExists();
+            } else {
+                is = getInputStream();
+                return is != null;
+            }
         } catch (IOException ex) {
             return false;
         } finally {



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

--
------------------------------------------------------------------------
Alexey N. Solofnenko <http://trelony.cjb.net/>
Pleasant Hill, CA (GMT-8 usually)

smime.p7s
Description: S/MIME Cryptographic Signature