On 10/6/06, Peter Reilly <[EMAIL PROTECTED]> wrote:
.......
> >
> > Looking at
http://www.jpackage.org/cgi-bin/viewvc.cgi/rpms/free/ant/?root=jpackage&pathrev=JPACKAGE-1_7
> > I think that we can get most of these patches into ant directly except
> > for apache-ant-bz163689.patch.
> >
> That would be wonderful.
I have had a quick check:
apache-ant-1.6.5-jvm1.5-detect.patch (detection of java 1.5 that
works with kaffe)
and apache-ant-jars.patch (do not have the same classes in multiple jars)
are already implemented in the ant 1.7 code base
as regards apache-ant-1.6-rpm.patch
I am a little confused as to what it does, and why
the -lib option to antlauncher was not used instead,
however I am happy to add it if that is what is wanted.
>
> W.r.t. to Aapache-ant-bz163689.patch that should be disabled there. It
> is some GCJ-related issue that has sneaked-in in some merge. I will
> remove it. Thanks to bring it to my attention :-)
> > There is one change I would like in jpackage, it is to do with the
> > /etc/ant.conf. It gets "dot" ed from the ant bash
> > script. It overwrites ANT_HOME (unless the -noconfig option is set).
> > This has given rise
> > to a large number of e-mails to user@ant.apache.org, and a number of
> > bug reports:
> >
> > http://issues.apache.org/bugzilla/show_bug.cgi?id=40623
> > http://issues.apache.org/bugzilla/show_bug.cgi?id=31278
> > + others
> >
> > the ant script file has been altered to whine if /etc/ant.conf changes
> > the user's ANT_HOME.
> > One suggestion is that /etc/ant.conf does not modify ANT_HOME if it is
already
> > set - ANT_HOME=${ANT_HOME:-/usr/share/ant}, however this I think does not
> > work as $rpm_mode will still be set, and ant will be called with the
> > user's ANT_HOME/lib/*.jar
> > and the contents of /etc/ant.d/*.
> > I think that /etc/ant.conf should *not* be called if the env variable
> > ANT_HOME is set but
> > would need to get agreement from jpackage people before doing this.
> >
>
> For this part I would like to hear from the people who actually maintain
> this mechanism here at JPackage.
I have modified the ant script to
*NOT* dot include /etc/ant.conf if ANT_HOME is set.
The reasoning is that if ANT_HOME is set, there is a 99%
chance that the user will not want ANT_HOME to be set
to something else, or that the user wants "rpm_mode" which
will cause the contents of /etc/ant.d/* to be added to the ant classpath.
This can be rolled back if there are objections.
I have also patched in apache-ant-1.6-rpm.patch.
So there should now be no need for any jpackage patches.
Peter
>
> Jason? David? Ralph?
>
> Thanks again for your help.
>
> Best regards,
> Fernando
> _______________________________________________
> JPackage-discuss mailing list
> [EMAIL PROTECTED]
> https://www.zarb.org/mailman/listinfo/jpackage-discuss
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
