Hi, I would also not make the behavior of defaultexcludes conditional upon an environment variable.
I would also go to inconditionnally hardwire exclude _svn directories. Regards, Antoine -------- Original-Nachricht -------- Datum: Tue, 15 Aug 2006 11:53:21 -0500 Von: "Dominique Devienne" <[EMAIL PROTECTED]> An: "Ant Developers List" <dev@ant.apache.org> Betreff: Re: AW: Default excludes and Subversion on Windows > > Accessing environment variables from Java is a hack. Do we want to > always > > execute it? In case of failure, normal build execution can be affected, > even > > if people do not care about "_svn" directory names. > > Not in JDK 1.5+ anymore. But I agree than fetching the env if that > user hasn't explicitly done it already is a bit heavy handed. > > I hesitate between Stefan's position of requiring the user to do it > explicitly and adding it to the default excludes. Since > <defaultexcludes> allows both adds and removes, I guess adding it to > the hardwired defaults (unconditionally, no env fetching) would > benefit more people, and Kev and others can still do an explicit > <defaultexcludes remove="**/_svn/**>, although I guess a remove is > trickier, since requires knowing the exact pattern to remove. > > --DD > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
