DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=19845>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=19845





------- Additional Comments From [EMAIL PROTECTED]  2005-12-21 00:37 -------
The patch can't be accepted as-is because it breaks backwards-compatibility;
i.e. there could (farfetched I know) be builds in the wild that depend on this
failure.  What you can do is make the desired behavior conditional upon a new
attribute, e.g. failonerror (default true) or the like.  In the meantime you can
work around this lack "old-school-Ant-style":

<target name="main" depends="check,filters,nofilters">
  <mycopy file="foo" tofile="bar" />
</target>
<target name="check">
  <available property="found" file="filtersfile" />
</target>
<target name="filters" if="found">
  <presetdef name="mycopy">
    <copy>
      <filterset>
        <filtersfile file="filtersfile" />
      </filterset>
    </copy>
  </presetdef>
</target>
<target name="nofilters" if="found">
  <presetdef name="mycopy">
    <copy />
  </presetdef>
</target>

Okay, the presetdef isn't old-school, but the target arrangement was what I was
talking about... ;)

HTH,
Matt

P.S. if you update your patch, prepend [PATCH] to the bug summary!

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to