Hi

During cleaning up last weekend I noticed something "funny", and hoped for a reaction. Here is the request distilled out of the entire commit message:

[EMAIL PROTECTED] wrote

I think there is an error in ConCat, see added comment. 1.46 +4 -1 ant/src/main/org/apache/tools/ant/taskdefs/Concat.java Index: Concat.java
 ===================================================================
 RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Concat.java,v
 retrieving revision 1.45
 retrieving revision 1.46
 diff -u -r1.45 -r1.46
 --- Concat.java        12 Jun 2005 15:54:14 -0000      1.45
 +++ Concat.java        12 Jun 2005 17:55:14 -0000      1.46
 @@ -431,6 +431,10 @@
              if (!outofdate) {
                  for (Iterator i = existRc.iterator(); !outofdate && 
i.hasNext();) {
                      Resource r = (Resource) i.next();
+ //TODO jkf, Seems the following code, or code like the + //following code is missing, can someone confirm? + //outofdate = (r.getLastModified()==0L || + // r.getLastModified() > destinationFile.lastModified())
                  }
              }
              if (!outofdate) {

Martijn

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to