--- Stefan Bodewig <[EMAIL PROTECTED]> wrote:
> On Wed, 30 Mar 2005, Matt Benson
> <[EMAIL PROTECTED]> wrote:
> 
> > Update:  I have been rolling this stuff around and
> I
> > am nearly ready to have something to show.
> 
> I really like what you've described.

well, hey! :)
> 
> > I have also modified fileset, dirset, filelist and
> > path to implement ResourceCollection.
> 
> Have you modified AbstractFileSet or the individual
> subclasses?

Good question; I almost answered it in the original
mail.  I figured we had little control over what
happens to AFS children so I implemented the new
interface in FileSet and DirSet directly.  Plus this
gives us encapsulated behavior (for the first time)
whereby a fileset consists of files and a dirset
consists of directories.

> > 1) a name for a ResourceCollection that acts like
> a
> > Union without removing duplicates.
> 
> What would it be used for?  It is not a set
> operation that way and I'm
> not familiar enough (at least the english terms of)
> with list theory
> (if there is something like that at all).  append? 
> join?

Referencing Kev's followup, I actually chose concat as
the first "real" task to adapt (I've actually already
done length and pathconvert because they are
invaluable testing aids), and this collection is one I
wanted concat to use internally, but I thought it
might be usable elsewhere.  With Kev having mentioned
"concatenate" but not having a name for the noun
created by the verb... "concatenation"?  It really
stood out since that's what I wanted it for in the
first place.  Thanks Kev!
> 
> > 2) should there be a reference-only (resources)
> type
> > that can generically use a ResourceCollection of
> an
> > unknown type?
> 
> What would it be used for?

The idea of "this task creates a ResourceCollection
with the specified reference."  Okay, I invoke the
task, now I have a reference to an RC, but I don't
know its type, thus <resources refid="foo" />

> 
> > Finally, I would like to reach a consensus on the
> approach I should
> > take to adding this; dump it all into CVS HEAD or
> create a sandbox
> > area?
> 
> I'd go for CVS HEAD unless anybody else objects.

Easier for me.  :)
> 
> > If the latter, I am still a little unclear on what
> tricks could be
> > used to make it easier to use modified core code
> in a sandbox and
> > would appreciate advice from other committers.
> 
> I once did so for the input proposal and I think the
> original antlib
> code did as well.  Basically you add your versions
> of all classes that
> you need to modifiy to the sandbox and when you
> compile you make sure
> your versions are before Ant's classes in the
> CLASSPATH.
> 
That doesn't sound too bad.  :)

Thanks,
Matt

> Stefan
> 
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> [EMAIL PROTECTED]
> For additional commands, e-mail:
> [EMAIL PROTECTED]
> 
> 


                
__________________________________ 
Do you Yahoo!? 
Yahoo! Mail - Easier than ever with enhanced search. Learn more. 
http://info.mail.yahoo.com/mail_250

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to