peterreilly 2005/03/14 08:39:03
Modified: src/main/org/apache/tools/ant/taskdefs/optional/ccm
CCMCheck.java CCMCheckinDefault.java
CCMCreateTask.java CCMReconfigure.java
Continuus.java
Log:
checkstyle - mostly javadoc
Revision Changes Path
1.22 +4 -1
ant/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMCheck.java
Index: CCMCheck.java
===================================================================
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMCheck.java,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- CCMCheck.java 9 Mar 2004 16:48:15 -0000 1.21
+++ CCMCheck.java 14 Mar 2005 16:39:03 -0000 1.22
@@ -1,5 +1,5 @@
/*
- * Copyright 2001-2004 The Apache Software Foundation
+ * Copyright 2001-2005 The Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -40,6 +40,7 @@
protected Vector filesets = new Vector();
+ /** Constructor for CCMCheck. */
public CCMCheck() {
super();
}
@@ -98,6 +99,7 @@
/**
* Adds a set of files to copy.
+ * @param set the set of files
*/
public void addFileset(FileSet set) {
filesets.addElement(set);
@@ -110,6 +112,7 @@
* Builds a command line to execute ccm and then calls Exec's run method
* to execute the command line.
* </p>
+ * @throws BuildException on error
*/
public void execute() throws BuildException {
1.14 +3 -1
ant/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMCheckinDefault.java
Index: CCMCheckinDefault.java
===================================================================
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMCheckinDefault.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- CCMCheckinDefault.java 9 Mar 2004 16:48:15 -0000 1.13
+++ CCMCheckinDefault.java 14 Mar 2005 16:39:03 -0000 1.14
@@ -1,5 +1,5 @@
/*
- * Copyright 2001-2002,2004 The Apache Software Foundation
+ * Copyright 2001-2002,2004-2005 The Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -24,12 +24,14 @@
*/
public class CCMCheckinDefault extends CCMCheck {
+ /** Constructor for CCMCheckinDefault. */
public CCMCheckinDefault() {
super();
setCcmAction(COMMAND_CHECKIN);
setTask(DEFAULT_TASK);
}
+ /** The default task */
public static final String DEFAULT_TASK = "default";
}
1.20 +11 -7
ant/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMCreateTask.java
Index: CCMCreateTask.java
===================================================================
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMCreateTask.java,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -r1.19 -r1.20
--- CCMCreateTask.java 9 Mar 2004 16:48:15 -0000 1.19
+++ CCMCreateTask.java 14 Mar 2005 16:39:03 -0000 1.20
@@ -1,5 +1,5 @@
/*
- * Copyright 2001-2004 The Apache Software Foundation
+ * Copyright 2001-2005 The Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -44,6 +44,9 @@
private String subSystem = null;
private String task = null;
+ /**
+ * Constructor for CCMCreateTask.
+ */
public CCMCreateTask() {
super();
setCcmAction(COMMAND_CREATE_TASK);
@@ -56,6 +59,7 @@
* Builds a command line to execute ccm and then calls Exec's run method
* to execute the command line.
* </p>
+ * @throws BuildException on error
*/
public void execute() throws BuildException {
Commandline commandLine = new Commandline();
@@ -264,7 +268,7 @@
/**
*
- * @exception java.io.IOException
+ * @throws IOException on error
*/
public void start() throws IOException {
}
@@ -277,16 +281,16 @@
/**
*
- * @param param1
- * @exception java.io.IOException
+ * @param param1 the output stream
+ * @exception java.io.IOException on error
*/
public void setProcessInputStream(OutputStream param1) throws
IOException {
}
/**
*
- * @param is
- * @exception java.io.IOException
+ * @param is the input stream
+ * @exception java.io.IOException on error
*/
public void setProcessErrorStream(InputStream is) throws IOException {
BufferedReader reader = new BufferedReader(new
InputStreamReader(is));
@@ -299,7 +303,7 @@
/**
* read the output stream to retrieve the new task number.
* @param is InputStream
- * @exception java.io.IOException
+ * @throws IOException on error
*/
public void setProcessOutputStream(InputStream is) throws IOException {
1.19 +5 -3
ant/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMReconfigure.java
Index: CCMReconfigure.java
===================================================================
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/ccm/CCMReconfigure.java,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- CCMReconfigure.java 15 Nov 2004 14:52:27 -0000 1.18
+++ CCMReconfigure.java 14 Mar 2005 16:39:03 -0000 1.19
@@ -1,5 +1,5 @@
/*
- * Copyright 2001-2004 The Apache Software Foundation
+ * Copyright 2001-2005 The Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -32,6 +32,7 @@
private boolean recurse = false;
private boolean verbose = false;
+ /** Constructor for CCMReconfigure. */
public CCMReconfigure() {
super();
setCcmAction(COMMAND_RECONFIGURE);
@@ -44,6 +45,7 @@
* Builds a command line to execute ccm and then calls Exec's run method
* to execute the command line.
* </p>
+ * @throws BuildException on error
*/
public void execute() throws BuildException {
Commandline commandLine = new Commandline();
@@ -69,11 +71,11 @@
*/
private void checkOptions(Commandline cmd) {
- if (isRecurse() == true) {
+ if (isRecurse()) {
cmd.createArgument().setValue(FLAG_RECURSE);
} // end of if ()
- if (isVerbose() == true) {
+ if (isVerbose()) {
cmd.createArgument().setValue(FLAG_VERBOSE);
} // end of if ()
1.16 +12 -1
ant/src/main/org/apache/tools/ant/taskdefs/optional/ccm/Continuus.java
Index: Continuus.java
===================================================================
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/ccm/Continuus.java,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- Continuus.java 9 Mar 2004 16:48:16 -0000 1.15
+++ Continuus.java 14 Mar 2005 16:39:03 -0000 1.16
@@ -1,5 +1,5 @@
/*
- * Copyright 2001-2004 The Apache Software Foundation
+ * Copyright 2001-2005 The Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -84,6 +84,12 @@
}
+ /**
+ * Run the command.
+ * @param cmd the command line
+ * @param handler an execute stream handler
+ * @return the exit status of the command
+ */
protected int run(Commandline cmd, ExecuteStreamHandler handler) {
try {
Execute exe = new Execute(handler);
@@ -96,6 +102,11 @@
}
}
+ /**
+ * Run the command.
+ * @param cmd the command line
+ * @return the exit status of the command
+ */
protected int run(Commandline cmd) {
return run(cmd, new LogStreamHandler(this, Project.MSG_VERBOSE,
Project.MSG_WARN));
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
