DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=33155>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=33155 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED Target Milestone|--- |1.7 ------- Additional Comments From [EMAIL PROTECTED] 2005-03-03 22:56 ------- I finally looked at this... thought it would be rude I committed the preservelastmodified patch and hadn't yet looked at this. Though this was a lot bigger. Kevin: WOW. I didn't want to have two sets of code in Ant that did the same thing. Plus two sets of unit tests that did the same thing. So I took your filter and renamed it to be completely distinct from FixCRLF the Task. I played around with the code a little 'cause I can't resist doing that. But I didn't even touch the real guts. I really like the way you implemented the various aspects of the task as separate filters. Anyway, I never tested your code; I set immediately about changing the task to use your filter. I figured if its testcases still passed after that we were in the clear. I got it converted and ran the test suite, and everything passed immediately. I was amazed. Anyway, I set the task up so that it can function as a filter just so we wouldn't have to do: <filterchain> <fixcrlffilter ... /> </filterchain> or something silly... instead it's just <fixcrlf ... /> just like the task. Anyway, this is very cool... I had wanted this filter for quite awhile but was too lazy to attack it myself. Looks like it represents a lot of work on your part. I have this marked down for Ant 1.7 now, though I may merge it for 1.6.3 depending on how much time elapses and whether any negative fallout shows up. Thanks! -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
