jkf 2005/03/03 05:58:25
Modified: src/main/org/apache/tools/ant AntClassLoader.java
Log:
Removed unecessary cast,
Removed caught Throwable while Exception was expected
Documented empty blocks
Revision Changes Path
1.89 +9 -2 ant/src/main/org/apache/tools/ant/AntClassLoader.java
Index: AntClassLoader.java
===================================================================
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/AntClassLoader.java,v
retrieving revision 1.88
retrieving revision 1.89
diff -u -r1.88 -r1.89
--- AntClassLoader.java 6 Jan 2005 12:05:06 -0000 1.88
+++ AntClassLoader.java 3 Mar 2005 13:58:25 -0000 1.89
@@ -518,10 +518,10 @@
if (cons.length > 0 && cons[0] != null) {
final String[] strs = new String[NUMBER_OF_STRINGS];
try {
- cons[0].newInstance((Object[]) strs);
+ cons[0].newInstance(strs);
// Expecting an exception to be thrown by this call:
// IllegalArgumentException: wrong number of Arguments
- } catch (Throwable t) {
+ } catch (Exception e) {
// Ignore - we are interested only in the side
// effect - that of getting the static initializers
// invoked. As we do not want to call a valid
@@ -1225,6 +1225,7 @@
* @param event the buildStarted event
*/
public void buildStarted(BuildEvent event) {
+ // Not significant for the class loader.
}
/**
@@ -1260,6 +1261,7 @@
* @since Ant 1.6.2
*/
public void subBuildStarted(BuildEvent event) {
+ // Not significant for the class loader.
}
/**
@@ -1268,6 +1270,7 @@
* @param event the targetStarted event
*/
public void targetStarted(BuildEvent event) {
+ // Not significant for the class loader.
}
/**
@@ -1276,6 +1279,7 @@
* @param event the targetFinished event
*/
public void targetFinished(BuildEvent event) {
+ // Not significant for the class loader.
}
/**
@@ -1284,6 +1288,7 @@
* @param event the taskStarted event
*/
public void taskStarted(BuildEvent event) {
+ // Not significant for the class loader.
}
/**
@@ -1292,6 +1297,7 @@
* @param event the taskFinished event
*/
public void taskFinished(BuildEvent event) {
+ // Not significant for the class loader.
}
/**
@@ -1300,6 +1306,7 @@
* @param event the messageLogged event
*/
public void messageLogged(BuildEvent event) {
+ // Not significant for the class loader.
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
