Most of the newer code in FileUtils is non-static, but most of the older code is static, is this a historical oddity, or is there a reason for it?
Also the contructor is protected, but there's no need as the getFileUtils always returns a new object. Why, wouldn't it be simpler to leave the constuctor as normal and use the class as a normal class, or to change the class to be a true Singleton, or to make it a completely static class?
Just some thoughts, there's probably a very good reason why it's the way it is, but I haven't figured it out yet.
Kev
Index: Concat.java
===================================================================
RCS file:
/home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/Concat.java,v
retrieving revision 1.37
diff -u -r1.37 Concat.java
--- Concat.java 21 Oct 2004 13:54:25 -0000 1.37
+++ Concat.java 10 Nov 2004 05:55:10 -0000
@@ -728,7 +728,7 @@
new InputStreamReader(new FileInputStream(file),
this.encoding));
}
- value = fileUtils.readFully(reader);
+ value = FileUtils.readFully(reader);
} catch (IOException ex) {
throw new BuildException(ex);
} finally {--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
