[EMAIL PROTECTED] wrote:
I was thinking last week that the compatibility logic should really be done before execution, not assignment. Because it makes it really, really hard to use the spawn option from tasks that create their own private instance to get things done, and setFailOnError(true); setFailOnError(false); gets mistakenly interpreted as an incompatible config.
-steve
Index: Java.java
===================================================================
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Java.java,v
retrieving revision 1.91
retrieving revision 1.92
diff -u -r1.91 -r1.92
--- Java.java 20 Apr 2004 06:52:48 -0000 1.91
+++ Java.java 23 Apr 2004 07:33:51 -0000 1.92
@@ -332,6 +332,7 @@
*/
public void setResultProperty(String resultProperty) {
this.resultProperty = resultProperty;
+ incompatibleWithSpawn = true;
}
/**
@@ -474,7 +475,7 @@
*/
public void setLogError(boolean logError) {
redirector.setLogError(logError);
- incompatibleWithSpawn = true;
+ incompatibleWithSpawn |= logError;
}
/**
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
