DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=28504>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=28504 [PATCH] Capitalize /ZIP|[JWE]AR/; update Zip.reset() overloads Summary: [PATCH] Capitalize /ZIP|[JWE]AR/; update Zip.reset() overloads Product: Ant Version: 1.7Alpha (nightly) Platform: All OS/Version: All Status: NEW Severity: Enhancement Priority: Other Component: Core tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The (undocumented yet protected!) field 'archiveType' in Zip currently is set to "zip", "jar", "war", or "ear". This patch capitalizes those values. I am not sure about "ZIP" vs. "Zip" (usage acc. to Google is inconsistent), but typically the other words as considered near-acronyms (_J_ava _AR_chive etc.) and should be in all caps. The archiveType is used in various messages and it looks bad IMHO to display e.g. Building jar: /tmp/foo.jar so the patch will produce Building JAR: /tmp/foo.jar Also "JAR archive" is technically redundant, just "JAR" is enough. Also it seems that some overloads of Zip.<init> had redundant calls which I commented out; and overloads of Zip.reset() were missing some attributes which were set in the constructor. I am not sure about this part of the patch since the documentation and intended usage of Zip.reset() seems vague - can't find any code which actually calls it, or any reason why just Zip and subclasses have such a method. Didn't notice any problems in Zip.cleanUp() overrides. Unit tests pass for me with this patch, though I am not sure how much Zip subclass functionality is currently actually tested. If there is some intended usage of Zip.archiveType that would have an API compatibility impact, i.e. changing the values would be incompatible for someone, then consider using String.toUpperCase(Locale.US) when using the value in Project.log messages. (Locale.US is necessary so that "zip" will become "ZIP" even in Turkish locale.) --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
