> -----Original Message-----
> From: Stefan Bodewig [mailto:[EMAIL PROTECTED]
> Sent: Friday, September 26, 2003 12:46 AM
> To: [EMAIL PROTECTED]
> Subject: Re: Task getTaskType() and setTaskType()
> 
> Given that there is no RuntimeConfigurable2 anymore, I'm not sure
> whether it really still needs to be public at all.  If it remains
> public, the getter should become public as well, I agree.
> 

Attached is a patch that makes getTaskType() public. I'm not sure if
setTaskType() should be public, private or protected.

-- Larry

Index: src/main/org/apache/tools/ant/Task.java
===================================================================
RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/Task.java,v
retrieving revision 1.50
diff -u -r1.50 Task.java
--- src/main/org/apache/tools/ant/Task.java     12 Sep 2003 20:56:45 -0000      
1.50
+++ src/main/org/apache/tools/ant/Task.java     26 Sep 2003 17:55:08 -0000
@@ -493,7 +493,7 @@
      *
      * @return the type of task
      */
-    protected String getTaskType() {
+    public String getTaskType() {
         return taskType;
     }
 

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to