Antoine,
Since you have recently been playing with symlinks/FTP what are your thoughts on bug 14320?
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14320
-Gus
Stefan Bodewig wrote:
On Wed, 6 Aug 2003, Antoine Levy-Lambert <[EMAIL PROTECTED]> wrote:
1) concerning the inclusion of "" in includedDirectories
1a) change the implementation of RM_DIR in order not to delete the root dir of the fileset
or
1b) revert the inclusion of "" in includedDirectories and change
the tests + document the difference with DirectoryScanner
or our all time backwards compatibility saving option
1c) add a new attribute to <ftp> that controls the behavior.
I'm not sure it's worth it, no real opinion other than we shouldn't break backwards compatibility just to fix something that hasn't been perceived as broken so far.
2) Concerning the symbolic links
2a) keep the code change and simply mention it in WHATSNEW.
Then users who do not want to download symbolic link directories can simply set the corresponding attribute to false.
or
2b) add a flag in DirectoryScanner#setFollowSymlinks to record
the fact that follow symlinks has been explicitly set to true,
and only follow symlinks if the user mentioned it explicitly ?
or
2c) call setFollowSymlinks(false) in FTPDirectoryScanner's constructor. I.e. change the default value of the attribute and document it that way.
I'd be in favor of 2c).
Stefan
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
