On Thu, Jul 10, 2003 at 01:04:52PM +0200, Stefan Bodewig wrote:
> On Thu, 10 Jul 2003, Paul Nasrat <[EMAIL PROTECTED]> wrote:

> This is by far not enough, you'd get a major version from
> getMajorVersionNumber of 4, which in turn would cause getMainClass to
> fail.

My bad.  I really didn't look at the code closely enough.

> > This makes the task work with sane layouts such as
> > /usr/share/java/javacc.jar or lib/javacc.jar (eg for JPackage).
> 
> Taking /usr/share/java as an example, you'd have to set the task's
> javacchome attribute to "/usr/share/java/" with your patch, right?
> Line 339 in JavaCC.java will cause javacc to be invoked with
> -Dinstall.root=/usr/share/java - are you sure it will work properly
> with this?

Hmm, no you are right, I kludged lib/bin/javacc and then didn't look at
my patch closely enough.

I'll have another poke now.

Paul

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to