Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/junit FormatterElement.java JUnitTask.java

[Erik Hatcher]

While this can be a slippery slope if applied to all tasks/elements (I 
agree), it really has a lot of value in the case Peter mentions.  
XDoclet could also benefit from such a scheme (but it currently 
doesn't).

XDoclet uses DynamicConfigurator, though, so it could be implemented 
using that mechanism rather than explicit support for if/unless.

        Erik
On Wednesday, May 28, 2003, at 10:31  AM, peter reilly wrote:
On Wednesday 28 May 2003 15:04, Conor MacNeill wrote:
On Wed, 28 May 2003 11:27 pm, Erik Hatcher wrote:
If folks feel strongly about it, I'll revert it.
I'm not into strong feelings :-). Let's see what people think.
+1 to keep the if attribute
I use this all the time with cc:
    <compiler id="compiler.options">
        <compilerarg value="-ggdb" unless="optimize"/>
        <compilerarg value="-pthread" if="is.linux"/>
        <compilerarg value="-Wall"/>
        <compilerarg value="-Wstrict-prototypes"/>
        <compilerarg value="-O3" if="optimize"/>
        <compilerarg value="-mcpu=pentium4" if="linux"/>
    </compiler>
Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]