On Thu, 22 May 2003, peter reilly <[EMAIL PROTECTED]> wrote: > Ok I will chop it up into a sequence of patches.
Thanks. > The first patch adds the add(Type) introspection method and > implements this in condition, filterchain, tokenfilter, selector and > path. I'm +1 for this patch, and only have three nits, none of which require yet another patch IMHO: * I'd like to have a null check on obj in ComponentHelper.createComponent before passing it to project or invoking init on it. * I'd like to see some more braces in one-line ifs 8-) * some more @since tags would be nice (I said it would be nits ;-) Stefan
