Antoine Levy-Lambert wrote: > I am having a look at > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19897 > > This proposal seems to address most of the points discussed in this > mailing list concerning the antlib thread of discussion. > > I was thinking maybe we do not need to look further and we could commit > this contribution ? > > I would be glad to hear your comments concerning : > 1) the functionality provided by the contribution > 2) the implementation > I am quoting Peter Reilly here : > > This patch adds 4 new features (the code is interrelated, > but may be split). > * adapter attribute added to typedef
+1 > * add(Type) method added to introspection rules +1 > * typedef can read an xml defintion file +1 - but I need further review of the XML DTD ( and maybe some changes ) > * namespace support for xml defintions (antlib:) > So one can do > <project xmlns:acme="org.acme.anttasks"> > <acme:hello> > <path path="build.xml"/> > </acme:hello> > </project> +1 We should also support the <antlib classpath="cp" resource="..." uri="NSURI> <acme:hellp xmlns:acme="NSURI" > This would allow arbitrary NSURIs ( for people who like meaning-free URIs) and allow the classpath association. Costin
