dheerajturaga commented on PR #55301: URL: https://github.com/apache/airflow/pull/55301#issuecomment-3263936822
> I was not able to commit to your repo, Github gave me the following error :-( > > ``` > > jscheffl@hp860g9:~/Workspace/airflow_review$ git push > > error: Authentication error: Authentication required: You must have push access to verify locks > > error: failed to push some refs to 'github.com:dheerajturaga/airflow.git' > > ``` > > > > Therefore (1) added commits 1-3 from my additions as recommondations/comments. Did not pply them because generated and compiled code was not possible to be added by this ... you need to apply and compile UI. > > > > Alternatively opened a DRAFT PR, you can also easily `git cherry-pick` from there: > > https://github.com/apache/airflow/pull/55348: > > 1. [Add tooltips to buttons](https://github.com/apache/airflow/pull/55348/commits/fdd0c2b0f7eeeda79a8e00cec50a7417ef0f9406) > > 2. [Have exit button not if it is in maintenance exit already](https://github.com/apache/airflow/pull/55348/commits/119ad58cecb4155a23a88783bfb6e96ea26ae37c) > > 3. [Add authentication to (new) API endpoints](https://github.com/apache/airflow/pull/55348/commits/ec77bd65b96fd27eb601aeda51d4fb92354bc301) > > > > My change attempt to make a proper dialog in commit 4 / [Rework maintenance dialog to be a dialog](https://github.com/apache/airflow/pull/55348/commits/7e6d13cf316711f286e3262fa8552b2d62ede965) as not successful, asked in Slack if I am tooo stupid... I assume to need help on this. > > So to un-block the efforts, maybe if commits 1-3 are cherry picked it is OK to merge and then applying beautification later? @jscheffl sure thing! Let me cherry pick these and re compile the assets in a couple of hours. Lets merge if base functionality is available and cleanup the UI in subsequent PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
