potiuk commented on code in PR #55342:
URL: https://github.com/apache/airflow/pull/55342#discussion_r2328550417
##########
dev/i18n/check_translations_completeness.py:
##########
@@ -478,16 +489,31 @@ def cli(language: str | None = None, add_missing: bool =
False):
else:
lang_diff = print_language_summary(locale_files, summary, console)
found_difference = found_difference or lang_diff
- has_todos = print_translation_progress(
+ has_todos, coverage_per_language = print_translation_progress(
console,
[lf for lf in locale_files if language is None or lf.locale ==
language],
missing_counts,
summary,
)
if not found_difference and not has_todos:
- console.print("\n[green]All translations are complete and
consistent![/green]\n\n")
+ console.print("\n[green]All translations are complete![/green]\n\n")
else:
- console.print("\n[red]Some translations are neither complete nor
consistent![/red]\n\n")
+ console.print("\n[red]Some translations are not complete![/red]\n\n")
+ # Print summary of total coverage per language
+ if coverage_per_language:
+ summary_table = Table(show_header=True, header_style="bold
magenta")
+ summary_table.title = "Total Coverage per Language"
+ summary_table.add_column("Language", style="cyan")
+ summary_table.add_column("Coverage", style="green")
+ for lang, coverage in sorted(coverage_per_language.items()):
+ if coverage >= 95:
Review Comment:
Not sure if those are good thresholds @shahar1 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
