jscheffl commented on PR #55277: URL: https://github.com/apache/airflow/pull/55277#issuecomment-3263753374
> Hello @jscheffl I just updated all the work and PR description, could you review it again, thx! > > @guan404ming, @RoyLee1224 since last time of your review, colud you also help me to review with this PR, thx! I see no change in regards to - was this missed-out? Or do you have a strong preperence to the proposed PR solution with a JSON? Then I'd need some arguments to convince me. - In PR https://github.com/apache/airflow/pull/54783 we also had a discussion about passing form values as JSON dict. In my view this makes it complex because a user who constructs a URL must make a proper JSON and encode the data in the URL properly. Finally we came to the point in passing individual key/vale pairs and not a JSON dict. See also https://github.com/apache/airflow/pull/54783#issuecomment-3217154737 - I'd wish to make it consistent here as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
