mangal-vairalkar commented on PR #54617: URL: https://github.com/apache/airflow/pull/54617#issuecomment-3263729812
Hi Jens Scheffler thanks for pointing this out 🙏 I’ve updated the example as suggested: Renamed the file from example_oracle_ingest.py → example_oracle_fetch.py Updated the DAG ID and references consistently CI checks have passed ✅ — this should resolve the earlier concern. Please let me know if you’d like any further adjustments. On Fri, Sep 5, 2025 at 11:49 AM Jens Scheffler ***@***.***> wrote: > ***@***.**** commented on this pull request. > > In general looks good but am wondering about the naming a bit. > ------------------------------ > > On > providers/src/airflow/providers/oracle/example_dags/example_oracle_ingest.py > <https://github.com/apache/airflow/pull/54617#discussion_r2325811491>: > > You call this "example oracle *ingest*" but actually you make a fetch in > the example? Do you mind renaming the file accordingly? (and the Dag name > as well) > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/airflow/pull/54617#pullrequestreview-3190451480>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BVCTOMKWHDNONKT2WUGGWZD3RHLNBAVCNFSM6AAAAACEFJHBGWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCOJQGQ2TCNBYGA> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
