Regenerating the docs with those two commits fixed the issues in staging - both security model and the diagrams are ok now in staging :)
On Tue, Aug 5, 2025 at 2:11 PM Jarek Potiuk <ja...@potiuk.com> wrote: > > Testing status issue https://github.com/apache/airflow/issues/54124 > > Cool. Checked all changes I was involved in .... still +1. (binding) > > While doing so - I found a bug (documentation only) - we miss icons in > generated diagrams due to one PR not cherry-picked to v3-0-test ( > https://github.com/apache/airflow/pull/54129) - but we can fix this at > doc-generation time using the new feature we have allowing to patch > documentation while building it using later cherry-picks. I will test it > shortly and regenerate the staging docs with those two cherry-picks to test > it before final release :) > > Before I patch it, you can see the funny bug here: > https://airflow.staged.apache.org/docs/apache-airflow/stable/core-concepts/overview.html#separate-dag-processing-architecture > > https://ibb.co/svpGKJPq > > > [image: Screenshot 2025-08-05 at 14.09.32.png] > > I am so happy we have the staging documentation step now as part of the > release :) > > J. > > > > > On Tue, Aug 5, 2025 at 1:51 PM Scheffler Jens (XC-AS/EAE-ADA-T) > <jens.scheff...@de.bosch.com.invalid> wrote: > >> @Ash, @Jarek, >> >> I can check today at home. I also suspect just the order of files or >> non-relevant meta data being different. >> Tar-Balls: Binary different - will inspect later >> Expended source: Binary identical >> >> I assume this is not blocking the release because we care about the >> content and the source and binary (also WHL) was reproducible. >> >> -----Ursprüngliche Nachricht----- >> Von: Jarek Potiuk <ja...@potiuk.com> >> Gesendet: Dienstag, 5. August 2025 12:37 >> An: dev@airflow.apache.org >> Betreff: Re: [VOTE] Release Airflow 3.0.4 from 3.0.4rc1 & Task SDK 1.0.4 >> from 1.0.4rc1 >> >> BTW. I can - of course - help with regenerating and posting the issue if >> need be and there are some issues with it. Happy to fix those if needed. >> >> On Tue, Aug 5, 2025 at 12:30 PM Jarek Potiuk <ja...@potiuk.com> wrote: >> >> > +1 (binding): >> > >> > Done: >> > >> > * reproducible package check (passed - same as for Amog) >> > * SVN checks >> > * Docker checks >> > * Licence checks >> > * signatures >> > * checksums >> > * installed and run it with Breeze >> > >> > >> > Few comments: >> > >> > * Jens - indeed reproducibility for tarball worked for me as well. I >> > think it would be great if you run `diffoscope` (you can run it with >> > `uv tool install diffoscope`) on the two tarballs and share the >> > difference (can be on Slack) so that we can take a look and fix it. It >> > is likely some permission issue or sequence of adding files to tar - >> > our process attempts to make all that reproducible, but maybe >> > something is only affecting your environment :). >> > >> > * I see my security model update >> > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith >> > ub.com%2Fapache%2Fairflow%2Fpull%2F54088&data=05%7C02%7CJens.Scheffler >> > %40de.bosch.com%7C4716ab8309404009829708ddd40c1782%7C0ae51e1907c84e4bb >> > >> b6d648ee58410f4%7C0%7C0%7C638899870598876472%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=E%2FdwvgUch5qktLIB3DCJYB7uNAj%2BnAwdREnef1gybvE%3D&reserved=0 >> did not make it, it's already cherry-picked to v3-0-test and I can apply it >> after the release (or Ash can do it when releasing docs) with our new tool >> where we can release docs with individual cherry-picks applied. >> > >> > Ash - is there any reason why we have no "Status of testing" issue >> > generated? Was it failing maybe ? I feel a bit lost not seeing the >> > issue where I see all the issues I should look like - it makes the >> > manual verification part way easier. And I see the part where we >> > generate it is in the docs. Also I think it has a very good >> > "collaboration" spirit where it allows people to encourage each other >> > to do testing and report on their status. >> > >> > All looks good besides. >> > >> > >> > J >> > >> > On Tue, Aug 5, 2025 at 11:37 AM Amogh Desai <amoghde...@apache.org> >> wrote: >> > >> >> +1 binding. >> >> >> >> For both airflow-core and task-sdk: >> >> - Checked reproducible package builds >> >> - Performed SVN checks >> >> - Checked Licenses >> >> - Checked Signatures >> >> - Checked SHA512 checksums >> >> >> >> Installed the RC with breeze, and tested my changes and also ran a >> >> general test of running dags from my test set. Looking good! >> >> >> >> Jens, I do not see a difference in the source tarball being different >> >> when I test it. >> >> We also perform raw byte comparison between tarballs, so I am not so >> >> sure why you see that error. >> >> >> >> Thanks & Regards, >> >> Amogh Desai >> >> >> >> >> >> On Tue, Aug 5, 2025 at 3:22 AM Jens Scheffler >> >> <j_scheff...@gmx.de.invalid >> >> > >> >> wrote: >> >> >> >> > Hi Ash! >> >> > >> >> > Tested 3.0.4RC1 with latest EdgeExecutor and Integration Test DAG >> >> > and all looks good! >> >> > >> >> > Airflow-Core 3.0.4rc1: +1 (binding) - Checked SVN, Reproducible >> >> > package build, Licenses, Signatures >> >> > >> >> > I am not sure why the source tarball is binary different when I >> >> > build locally but inspecting the content it seems to be binary same >> content. >> >> > So I assume some file order or unrelevant meta data is different >> >> > from the packaging locally and from Ash. Maybe MacOS to Linux small >> >> > diff in tar/gz? >> >> > >> >> > Task SDK 1.0.4RC1: +1 (binding) - Checked SVN, Reproducible package >> >> > build, Licenses, Signatures >> >> > >> >> > Nit in Release Notes: >> >> > >> >> > The line `Flexible form use ReactMarkdown instead of default >> >> > Markdown component (#54032) (#54040)` is duplicate in the list >> >> > >> >> > Thanks for driving the release! >> >> > >> >> > Jens >> >> > >> >> > On 04.08.25 19:28, Ash Berlin-Taylor wrote: >> >> > > Hey fellow Airflowers, >> >> > > >> >> > > The release candidates for *Apache Airflow 3.0.4rc1 *and *Task >> >> > > SDK >> >> > 1.0.4rc1* are now available for testing! >> >> > > >> >> > > This email is calling for a vote on the release, which will last >> >> > > at >> >> > least until 7th August (72 hours from now) and until 3 binding +1 >> >> > votes have been received. >> >> > > >> >> > > Consider this my +1 binding vote. >> >> > > >> >> > > Airflow 3.0.4rc1 is available at: >> >> > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2 >> >> > > Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fairflow%2F3.0.4rc1%2F&dat >> >> > > a=05%7C02%7CJens.Scheffler%40de.bosch.com%7C4716ab830940400982970 >> >> > > 8ddd40c1782%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C63889987 >> >> > > 0598909161%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOi >> >> > > IwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C >> >> > > 0%7C%7C%7C&sdata=u82JBzsWqP91l18n7z90VKY3BhUcMZsErFuSfaG5aJ0%3D&r >> >> > > eserved=0 >> >> > > >> >> > > "apache-airflow" Meta package: >> >> > > >> >> > > - *apache-airflow-3.0.4-source.tar.gz* is a source release that >> >> > > comes >> >> > with INSTALL instructions. >> >> > > - *apache-airflow-3.0.4.tar.gz* is the binary Python "sdist" >> release. >> >> > > - *apache_airflow-3.0.4-py3-none-any.whl* is the binary Python >> >> > > wheel >> >> > "binary" release. >> >> > > >> >> > > >> >> > > "apache-airflow-core" package >> >> > > >> >> > > - *apache_airflow_core-3.0.4.tar.gz* is the binary Python “sdist" >> >> > release. >> >> > > - *apache_airflow_3.0.4-py3-none-any.whl* is the binary Python >> >> > > wheel >> >> > "binary" release. >> >> > > >> >> > > >> >> > > Task SDK 1.0.4rc1 is available at: >> >> > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2 >> >> > > Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fairflow%2Ftask-sdk%2F1.0. >> >> > > 4rc1%2F&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7C4716ab8309 >> >> > > 404009829708ddd40c1782%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0 >> >> > > %7C638899870598933159%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnR >> >> > > ydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoy >> >> > > fQ%3D%3D%7C0%7C%7C%7C&sdata=uiLBAPu0z1mymBMONmWnGZXfn9u9ljUh5M3zw >> >> > > qDvfaw%3D&reserved=0 >> >> > > >> >> > > "apache-airflow-task-sdk" package >> >> > > >> >> > > - *apache_airflow_task_sdk-1.0.4.tar.gz* is the binary Python >> “sdist" >> >> > release. >> >> > > - *apache_airflow_task_sdk-1.0.4-py3-none-any.whl* is the binary >> >> Python >> >> > wheel "binary" release. >> >> > > >> >> > > Public keys are available at: >> >> > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2 >> >> > > Fdist.apache.org%2Frepos%2Fdist%2Frelease%2Fairflow%2FKEYS&data=0 >> >> > > 5%7C02%7CJens.Scheffler%40de.bosch.com%7C4716ab8309404009829708dd >> >> > > d40c1782%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C63889987059 >> >> > > 8949885%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwL >> >> > > jAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7 >> >> > > C%7C%7C&sdata=4VhIlQLWZbz1WJtU%2FGEmD%2FHcLLuBSWwoR%2FW0BxXXGcc%3 >> >> > > D&reserved=0 >> >> > > >> >> > > Please vote accordingly: >> >> > > >> >> > > [ ] +1 approve >> >> > > [ ] +0 no opinion >> >> > > [ ] -1 disapprove with the reason >> >> > > >> >> > > Only votes from PMC members are binding, but all members of the >> >> > community are encouraged to test the release and vote with >> >> "(non-binding)". >> >> > > >> >> > > The test procedure for PMC members is described in: >> >> > > >> >> > >> >> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit >> >> hub.com%2Fapache%2Fairflow%2Fblob%2Fmain%2Fdev%2FREADME_RELEASE_AIRFL >> >> OW.md%23verify-the-release-candidate-by-pmc-members&data=05%7C02%7CJe >> >> ns.Scheffler%40de.bosch.com%7C4716ab8309404009829708ddd40c1782%7C0ae5 >> >> 1e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638899870598967459%7CUnknown%7 >> >> CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4z >> >> MiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=YO1lSdP0yuD%2 >> >> FOpYvIhZImVdnOWRbbvuS0SLcX5PnHOc%3D&reserved=0 >> >> > > >> >> > > The test procedure for contributors and members of the community >> >> > > who >> >> > would like to test this RC is described in: >> >> > > >> >> > >> >> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit >> >> hub.com%2Fapache%2Fairflow%2Fblob%2Fmain%2Fdev%2FREADME_RELEASE_AIRFL >> >> OW.md%23verify-the-release-candidate-by-contributors&data=05%7C02%7CJ >> >> ens.Scheffler%40de.bosch.com%7C4716ab8309404009829708ddd40c1782%7C0ae >> >> 51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638899870598986584%7CUnknown% >> >> 7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4 >> >> zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=yhmhTUUVb46m >> >> siTKOjDgXQE%2BZTKDnnAMobA82C0cbgg%3D&reserved=0 >> >> > > >> >> > > Please note that the version number excludes the 'rcX' string, so >> >> > > it's >> >> > now simply 3.0.4 for Airflow package and 1.0.4 for Task SDK. This >> >> > will allow us to rename the artifact without modifying the artifact >> >> > checksums when we actually release. >> >> > > >> >> > > *Docs* (for preview): >> >> > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2 >> >> > > Fairflow.staged.apache.org%2Fdocs%2Fapache-airflow%2F3.0.4&data=0 >> >> > > 5%7C02%7CJens.Scheffler%40de.bosch.com%7C4716ab8309404009829708dd >> >> > > d40c1782%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C63889987059 >> >> > > 9003850%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwL >> >> > > jAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7 >> >> > > C%7C%7C&sdata=fjW5lB%2B1ywwVkgW6vFZKlmbGRypsZiGcKTyTGKWR4Gc%3D&re >> >> > > served=0 >> >> > > *Release Notes*: >> >> > > j >> >> > > - >> >> > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2 >> >> > > Fgithub.com%2Fapache%2Fairflow%2Fblob%2F3.0.4rc1%2FRELEASE_NOTES. >> >> > > rst&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7C4716ab83094040 >> >> > > 09829708ddd40c1782%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C6 >> >> > > 38899870599019561%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWU >> >> > > sIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3 >> >> > > D%3D%7C0%7C%7C%7C&sdata=tpXT0gthhMWn42YtMm4K01Pt03qap5Cd8RX52wdoy >> >> > > eA%3D&reserved=0 >> >> > > - >> >> > >> >> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fair >> >> flow.staged.apache.org%2Fdocs%2Fapache-airflow%2F3.0.4%2Frelease_note >> >> s.html&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7C4716ab830940400 >> >> 9829708ddd40c1782%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638899 >> >> 870599033910%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIw >> >> LjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7 >> >> C%7C&sdata=XBL8eTip9d0%2FOA7YJL5ijjdYj0MPTEfkh1Ga4bClIXQ%3D&reserved= >> >> 0 >> >> > (Rendered HTML) >> >> > > >> >> > > *Testing Instructions using PyPI*: >> >> > > >> >> > > You can build a virtualenv that installs this and other required >> >> packages >> >> > > (e.g. task sdk), like this: >> >> > > >> >> > > ``` >> >> > > uv venv >> >> > > uv pip install -U apache-airflow==3.0.4rc1 --pre ``` >> >> > > >> >> > > Constraints files are at >> >> > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2 >> >> > > Fgithub.com%2Fapache%2Fairflow%2Ftree%2Fconstraints-3.0.4rc1&data >> >> > > =05%7C02%7CJens.Scheffler%40de.bosch.com%7C4716ab8309404009829708 >> >> > > ddd40c1782%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638899870 >> >> > > 599051963%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiI >> >> > > wLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0 >> >> > > %7C%7C%7C&sdata=QhMg4zePgpzZlpsEqr6ENgjrACS7Vf9I0rF04a%2BIETU%3D& >> >> > > reserved=0 >> >> > > >> >> > > Cheers, >> >> > > Ash >> >> > >> >> > ------------------------------------------------------------------- >> >> > -- To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org >> >> > For additional commands, e-mail: dev-h...@airflow.apache.org >> >> > >> >> > >> >> >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org >> For additional commands, e-mail: dev-h...@airflow.apache.org >> >