Thank you Jarek! I hope to see you at the Airflow summit. Christos
On Thu, Jun 19, 2025 at 8:21 PM Jarek Potiuk <ja...@potiuk.com> wrote: > Looked at it -> added a few comments, this looks cool and rather clean - I > know Ash had a lot of concerns about the quality of previous integration - > so I guess it's up to him to also make the final review. > > I really like that we can finally get Otel traces in (and from what I hear, > we might even listen about it in Seattle ( > > https://airflowsummit.org/sessions/2025/beyond-logs-unlocking-airflow-3-0-observability-with-opentelemetry-traces/ > ) ? > I would really love to see some real-life open-telemetry showcases to see > how Airflow users might use it to get better diagnostics of what's going > on. > > J. > > On Thu, Jun 19, 2025 at 6:57 PM Christos Bisias <christos...@gmail.com> > wrote: > > > Hello, > > > > Can someone take a look at https://github.com/apache/airflow/pull/49180? > > > > It's a follow up PR for https://github.com/apache/airflow/pull/43941 > which > > changed the OpenTelemetry implementation but it got merged in a hurry due > > to the 3.0 release. At that time, we agreed to create a new PR for any > > leftovers. Unfortunately, the tests of the initial patch weren't enabled > to > > run in the CI. > > > > Apart from all the improvements and the small fixes, the most important > > change of the cleanup PR is enabling the tests on the CI so that people > > won't break the otel implementation unintentionally. > > > > Thank you in advance! > > > > Regards, > > Christos Bisias > > >
