Got it! Thanks :) On 2024/11/22 02:14:29 Wei Lee wrote: > Hi Vincent, > > Yep, I should have explained it better 🤦♂️ What I meant is whether we need > to raise a warning through Ruff for that breaking change (see "[LAZY > CONSENSUS] Use Ruff as the official linter to detect Airflow 3 > incompatibilities in user code” [1]) and whether I list it correctly. For > example, if it’s a renaming instead of a removal, then I need to fix this on > the list. Or maybe it contains something we should warn the users about, but > I did not. Either let me know through this mailing thread or the GitHub issue > so that I can fix it. Model change is probably one of the exceptions, as > we’re not allowing users to access db. We’ll probably just block > “airflow.models.*” till we decide how these should be fixed. (it seems to be > an ongoing thing, according to > https://github.com/apache/airflow/issues/41641#issuecomment-2485622598) > > Best, > Wei > > [1] https://lists.apache.org/thread/zzvhglssmljlfdypp3c7kj8c53f6nvdv > > > On Nov 21, 2024, at 9:00 PM, Vincent Beck <vincb...@apache.org> wrote: > > > > Hi Wei, > > > > Thanks for doing it. Pretty impressive the number of changes we did :) Just > > one clarification though (and sorry if it was mentioned somewhere else), > > what do you exactly mean by "If > > everything looks good, please click the checkbox in". Do you mean if the > > change listed is indeed a breaking change and should have a migration rule? > > I just do not want to click on that checkbox without be 100% sure of what I > > am doing :) > > > > On 2024/11/21 09:19:39 Wei Lee wrote: > >> Hi all, > >> > >> I just updated the rules before #44080 in > >> https://github.com/apache/airflow/issues/41641. I tried to compile the > >> rules as thoroughly as possible, but it would be great if folks could take > >> another look to see if these URLs make sense or if I missed anything. If > >> everything looks good, please click the checkbox in > >> https://github.com/apache/airflow/issues/41641#issuecomment-2490445543. > >> Thanks! > >> > >> Best, > >> Wei > >> > >> Wei Lee <weilee...@gmail.com> 於 2024年8月21日 週三 下午11:06寫道： > >> > >>> Hey everyone, > >>> > >>> We are currently implementing some breaking changes to the main branch. > >>> I've created this issue to keep track of the items that need to be > >>> included > >>> in our migration tool from version 2 to 3. I've provided two examples and > >>> will add more in the upcoming days. It would be great if we could consider > >>> migration rules and add them to this list whenever we make breaking > >>> changes. Thanks Jarek for pinning it in the GitHub issue. Currently, this > >>> process is manual. We'll explore easier ways to track it as we move > >>> forward. Thanks! > >>> > >>> https://github.com/apache/airflow/issues/41641 > >>> > >>> Best regards, > >>> Wei > >>> > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org > > For additional commands, e-mail: dev-h...@airflow.apache.org > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org > For additional commands, e-mail: dev-h...@airflow.apache.org > >
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org For additional commands, e-mail: dev-h...@airflow.apache.org
