I love it too. I just checked up on this today and my thoughts were exactly what Niko wrote. I commented on the channel on Slack, and realised that Jarek's reasoning makes sense, so I am going to correct myself!
Thanks & Regards, Amogh Desai On Thu, Oct 3, 2024 at 4:16 AM Jarek Potiuk <ja...@potiuk.com> wrote: > false positives -> false negatives of course :) > > On Wed, Oct 2, 2024 at 3:45 PM Jarek Potiuk <ja...@potiuk.com> wrote: > > > I love it too. > > > > I actually like the idea of having it in the same channel where we have > > discussions. This has the nice feature of being slightly "annoying" for > > those who use that channel. And being "slightly annoying" - is all but > > guaranteed that eventually someone will take care of the failures. This > is > > the "social" aspect of such integrations in the open-source community > that > > I think is quite important. > > > > One of the things such "annoying" notifications will have is that we > > (collectively) will have to make sure that we take better care about > false > > positives. > > > > And I really love that - we can add some retries etc. to make some > > regular "environmental" issues workaround, and if we will be sufficiently > > "annoyed" by the false positives to finally fix or workaround them, > that's > > a "net-positive" effect. > > > > J. > > > > > > > > On Wed, Oct 2, 2024 at 2:56 PM Oliveira, Niko > <oniko...@amazon.com.invalid> > > wrote: > > > >> I love this! Thanks for doing that! > >> > >> Have we considered sending the messages to a dedicated alerting channel? > >> E.g. #internal-airflow-ci-cd-alerts > >> That way you could set notifications to all messages of that channel, to > >> get a notification when main is failing, without getting a notification > for > >> every unrelated message that comes up in the existing > >> #internal-airflow-ci-cd channel (which has other discussions and topics > >> being discussed at any one time). > >> > >> Cheers, > >> Niko > >> > >> ________________________________ > >> From: rom sharon <r...@apache.org> > >> Sent: Wednesday, October 2, 2024 2:27:49 PM > >> To: dev@airflow.apache.org > >> Subject: [EXT] [ANNOUNCE] Slack notification for canary build failures > >> > >> CAUTION: This email originated from outside of the organization. Do not > >> click links or open attachments unless you can confirm the sender and > know > >> the content is safe. > >> > >> > >> > >> AVERTISSEMENT: Ce courrier électronique provient d’un expéditeur > externe. > >> Ne cliquez sur aucun lien et n’ouvrez aucune pièce jointe si vous ne > pouvez > >> pas confirmer l’identité de l’expéditeur et si vous n’êtes pas certain > que > >> le contenu ne présente aucun risque. > >> > >> > >> > >> I've set up Slack notifications for failed scheduled canary builds. (pr > >> <https://github.com/apache/airflow/pull/42394>) > >> These alerts will be sent to the #internal-ci-cd > >> <https://apache-airflow.slack.com/archives/C015SLQF059> channel. > >> > >> Feel free to join the channel and check for any failure notifications > that > >> appear. > >> > >> Thanks, Rom. > >> > > >
