As long as we can configure the auto-merge to automatically get turned off on a pr if someone pushes a new commit then I'm for it (I know it is possible to have it not reset when things change, but don't know if the opposite is true)
-ash On 13 September 2024 14:43:16 GMT-07:00, Jens Scheffler <j_scheff...@gmx.de.INVALID> wrote: >Hi Dev's, > >In our internal CI/CD discussions today after the summit we had a short >discussion about if we should enable "Auto Merge" in the Github repo for >PRs. > >TLDR: > >Does anything speaks against turning this on (anyway opt-in for committer)? > > >What? In Github (if feature enabled) this would allow that as a commiter >you mark a PR (manually and explicit) as Auto-Commit, ich sufficient >approvals and a green build would usually enable the button to merge, it >would automatically merge the PR. > >Why? When I raise a PR and have a fast Approval I sometimes need to keep >track of open PRs and wait until builds are green to merge. This takes a >bit of mental load to poll for build to be completed to press the button. > >Github docs: >https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request > >Note that this must be enabled by a committer on PR level explicitly. >Assumption is that technically it is the same for Git history and visu >as merged manually just that you don't need to sit and wait in front of >the UI waiting to turn the pipeline green. > >I would in parallel check if there is any legal or organizational "nogo" >in turning this on with ASF INFRA. And we probably would make a small >PoC to double check if this is all OK with the documented assumptions. > >Jens > > >--------------------------------------------------------------------- >To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org >For additional commands, e-mail: dev-h...@airflow.apache.org >
