Thank you Wei Lee, Can you please share a reproducible example that shows the regression? For the moment I do not understand what is the impact of this bug and who is affected thus there is not enough information to make a decision if this is a blocker for the release or not.
On Tue, Aug 8, 2023 at 5:55 PM Wei Lee <weilee...@gmail.com> wrote: > -1 (non-binding) on apache-airflow-providers-google==10.6.0rc2 > > In > https://github.com/apache/airflow/commit/e10aa6ae6ad#diff-529929b4ca60ce73b8da0f45d8a5c43c2d4e391b913fe78b39892899f812951eR2730, > a new property "sql" is introduced. We’re assigning some value to this sql > attribute which causes an error like the following. > > > ---------------------------------------------------------------------------------------- > self.operator.sql = self.operator.configuration["query"]["query"] > ../....../airflow/models/baseoperator.py:1044: in __setattr__ > super().__setattr__(key, value) > E AttributeError: can't set attribute > > ---------------------------------------------------------------------------------------- > > I try to send a fix to mitigate this. > https://github.com/apache/airflow/pull/33211 > > Best, > Wei > > > On Aug 8, 2023, at 6:18 PM, Jarek Potiuk <ja...@potiuk.com> wrote: > > > > +1 (binding) > > > > Checked my changes for redis. tested signatures, checksums, licences, > > sources are > > matching the tag. All looks good. > > > > > > On Tue, Aug 8, 2023 at 10:20 AM Elad Kalif <elad...@apache.org> wrote: > >> > >> Hey all, > >> > >> > >> I have just cut *RC2* Airflow Providers packages. This email is calling > a > >> vote on the release, > >> > >> which will last for *24 hours* - which means that it will end on August > 09, > >> 2023 08:17 AM UTC and until 3 binding +1 votes have been received.Vote > >> duration is according to shortened voting period policy as accepted in > this > >> thread < > https://lists.apache.org/thread/cv194w1fqqykrhswhmm54zy9gnnv6kgm>. > >> > >> > >> > >> Consider this my (binding) +1. > >> > >> > >> Airflow Providers are available at: > >> > >> https://dist.apache.org/repos/dist/dev/airflow/providers/ > >> > >> > >> *apache-airflow-providers-<PROVIDER>-*.tar.gz* are the binary > >> > >> Python "sdist" release - they are also official "sources" for the > provider > >> packages. > >> > >> > >> *apache_airflow_providers_<PROVIDER>-*.whl are the binary > >> > >> Python "wheel" release. > >> > >> > >> The test procedure for PMC members is described in > >> > >> > https://github.com/apache/airflow/blob/main/dev/README_RELEASE_PROVIDER_PACKAGES.md#verify-the-release-candidate-by-pmc-members > >> > >> > >> The test procedure for and Contributors who would like to test this RC > is > >> described in: > >> > >> > https://github.com/apache/airflow/blob/main/dev/README_RELEASE_PROVIDER_PACKAGES.md#verify-the-release-candidate-by-contributors > >> > >> > >> > >> Public keys are available at: > >> > >> https://dist.apache.org/repos/dist/release/airflow/KEYS > >> > >> > >> Please vote accordingly: > >> > >> > >> [ ] +1 approve > >> > >> [ ] +0 no opinion > >> > >> [ ] -1 disapprove with the reason > >> > >> > >> > >> Only votes from PMC members are binding, but members of the community > are > >> > >> encouraged to test the release and vote with "(non-binding)". > >> > >> > >> Please note that the version number excludes the 'rcX' string. > >> > >> This will allow us to rename the artifact without modifying > >> > >> the artifact checksums when we actually release. > >> > >> > >> The status of testing the providers by the community is kept here: > >> > >> https://github.com/apache/airflow/issues/33193 > >> > >> > >> You can find packages as well as detailed changelog following the below > >> links: > >> > >> > >> https://pypi.org/project/apache-airflow-providers-google/10.6.0rc2/ > >> https://pypi.org/project/apache-airflow-providers-redis/3.3.1rc2/ > >> > >> > >> Cheers, > >> > >> Elad Kalif > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org > > For additional commands, e-mail: dev-h...@airflow.apache.org > > > >
