Oh yes good point! I forgot that the shasum files contain the file
names.
On Mon, May 17 2021 at 13:52:05 +0100, Kaxil Naik <[email protected]>
wrote:
While working on the Helm Chart release, I was verifying what we were
doing for "apache-airflow/python dists" over the weekend, which is
"wrong".
We should be renaming the files as the SHA512 check fails on
"Release" repo:
<https://dist.apache.org/repos/dist/release/airflow/2.0.2/>
For example, check out 2.0.2 release on Airflow:
Since the SHA512 were generated with the original filename (with rc
in it), it fails now in filename part:
❯ for i in *.sha512
do
echo "Checking $i"; shasum -a 512 `basename $i .sha512 ` | diff
- $i
done
Checking apache-airflow-2.0.2-bin.tar.gz.sha512
1c1
<
4281b3ff5d5b483c74970f8128d7ad8ba699081086fd098e10b12f8b52a7d0f92a205d7ea334c29e813ac06af7a26de416294fd18c3a1a949388a4824955ce2e
apache-airflow-2.0.2-bin.tar.gz
---
>
4281b3ff5d5b483c74970f8128d7ad8ba699081086fd098e10b12f8b52a7d0f92a205d7ea334c29e813ac06af7a26de416294fd18c3a1a949388a4824955ce2e
apache-airflow-2.0.2rc1-bin.tar.gz
Checking apache-airflow-2.0.2-source.tar.gz.sha512
1c1
<
ca783369f9044796bc575bf18b986ac86998b007d01f8ff2a8c9635454d05f39fb09ce010d62249cf91badc83fd5b38c04f2b39e32830ccef70f601c5829dcb7
apache-airflow-2.0.2-source.tar.gz
---
>
ca783369f9044796bc575bf18b986ac86998b007d01f8ff2a8c9635454d05f39fb09ce010d62249cf91badc83fd5b38c04f2b39e32830ccef70f601c5829dcb7
apache-airflow-2.0.2rc1-source.tar.gz
Checking apache_airflow-2.0.2-py3-none-any.whl.sha512
1c1
<
779563fd88256980ff8a994a9796d7fd18e579853c33d61e1603b084f4d150e83b3209bf1a9cd438c4dd08240b1ee48b139690ee208f80478b5b2465b7183e50
apache_airflow-2.0.2-py3-none-any.whl
---
>
779563fd88256980ff8a994a9796d7fd18e579853c33d61e1603b084f4d150e83b3209bf1a9cd438c4dd08240b1ee48b139690ee208f80478b5b2465b7183e50
apache_airflow-2.0.2rc1-py3-none-any.whl
I was also checking how other projects did it, Apache Spark for
instance, they also just have the "rc" name in the directory and that
is all:
<https://dist.apache.org/repos/dist/dev/spark/v2.4.8-rc3-bin/> so it
is easy to "just move" from "dev" to "release" without changing
anything. I followed the "rc2" vote with all those in mind after some
discussion at <https://issues.apache.org/jira/browse/LEGAL-573> and
checking how other projects did it.
I intended to change our Airflow release guide today, will do in an
hour or so.
Regards,
Kaxil
On Mon, May 17, 2021 at 12:26 PM Ash Berlin-Taylor <[email protected]
<mailto:[email protected]>> wrote:
On Sun, May 16 2021 at 02:04:43 +0100, Kaxil Naik
<[email protected] <mailto:[email protected]>> wrote:
- "version"'s should not contain an "-rc" prefix to allow moving
and voted on artifact to "release" folder in ASF:
<https://dist.apache.org/repos/dist/release/airflow/> otherwise we
need to modify to update version which defeats the purpose of
voting.
For apache-airflow/python dists we do this slightly differently.
Anything _in_ the package or tarball should have the target version
(1.0.0 in this case) but the filename itself still contains the RC
suffix.
We should be able to do the same here for future votes
-ash
