On 01/03/17 16:32, Nicholas Matsakis wrote:
Something I learned the hard way is to avoid a sentence like this one:
"Does not fix #123."
Github will dutifully detect "fix #123" and close the corresponding issue. =)
On Wed, Mar 1, 2017 at 10:21 AM, Alan Jeffrey <[email protected]> wrote:
The other thing I learned the hard way is not to #NNNNN-mention any issues
that aren't to be closed when then PR is merged.
The full list of keywords is at
https://help.github.com/articles/closing-issues-via-commit-messages/
I don’t know of a problem with referring to issue numbers without these
keywords.
--
Simon Sapin
_______________________________________________
dev-servo mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-servo
