On 2016-07-18 11:27 AM, Simon Sapin wrote:
On 18/07/16 15:43, Josh Matthews wrote:
Hi folks! We turned off Appveyor builds about 1.5 months ago because
they were constantly failing while building SpiderMonkey, and we just
had a few days where the TravisCI builds were permafailing unexpectedly.
I am pleased to report that we have re-enabled Appveyor, and the
TravisCI failures have been fixed. Please treat any CI failures observed
in PRs as blocking the merge once again!
Do we need to wait for the green tick on the PR before r+’ing, or does
bors/homu also run the same checks?
In theory it's redundant, since we have Windows and Linux builders. In
practice, the bustage that TravisCI observed could only be replicated by
removing _virtualenv in local environments or making a new clone of
Servo, and our non-Travis builders kept chugging along. Personally, I do
not think it's necessary to wait for the green checkmarks since the
overlap between our builders and our github CI is so high.
_______________________________________________
dev-servo mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-servo
