Hi Keith, Thanks for your valuable suggestion. However this time I created a new feature branch in my repository and merged this branch with master only after rebasing my master with upstream master.
Cheers!! Arpit On Mon, Mar 21, 2016 at 10:37 PM, Ravi Ashok Kumar Patel <[email protected]> wrote: > looping Arpit > > On Mon, Mar 21, 2016 at 9:37 PM, Keith Yeung <[email protected]> > wrote: > >> Hi Arpit, >> >> Just as a quick reminder, it's often a good idea to create a new feature >> branch when trying to make a PR. You'll inadvertently need to rebase >> against the changes in upstream master, so making a feature branch will >> prevent weird issues from happening whilst you're rebasing. >> >> Regards, >> Keith >> >> On Mon, Mar 21, 2016 at 3:27 PM, Arpit Tyagi <[email protected]> wrote: >> >>> Hi Josh, >>> >>> I believe, we have completed the coding for the initial steps, however I >>> am >>> not sure how can I test these changes. Could you please advise how can I >>> test these changes. >>> >>> I will also appreciate if you could have a quick look on code changes in >>> git (https://github.com/tyagiarpit/servo). >>> >>> Cheers!! >>> Arpit >>> >>> On Sun, Mar 20, 2016 at 10:41 PM, Josh Matthews <[email protected]> >>> wrote: >>> >>> > Welcome! Please ask questions here or on IRC if anything about the >>> project >>> > is unclear :) >>> > >>> > Cheers, >>> > Josh >>> > >>> > On 2016-03-19 5:39 PM, Ravi Ashok Kumar Patel wrote: >>> > >>> >> Hi, >>> >> >>> >> >>> >> >>> >> This is regarding the Student Project we are working on as part of our >>> >> curriculum at NC State University. >>> >> >>> >> >>> >> >>> >> Me and my team are working on "**Implement HTML5 form validation**" >>> for >>> >> servo >>> >> web browser engine. >>> >> >>> >> Following people are working on this project >>> >> >>> >> >>> >> >>> >> 1. Arpit Tyagi <[email protected]> >>> >> 2. Vinay Suryadevara <[email protected]> >>> >> 3. Ravi Patel <[email protected]> >>> >> We are being assisted by Sagar Muchhal <[email protected]> for >>> >> this >>> >> project >>> >> >>> >> >>> >> >>> >> Currently we are working on Initial Steps listed on wiki page >>> available on >>> >> github. >>> >> >>> >> >>> >> >>> >> Please let us know in case any further information is required >>> >> >>> >> >>> >> >>> >> Thanks >>> >> >>> >> >>> > >>> _______________________________________________ >>> dev-servo mailing list >>> [email protected] >>> https://lists.mozilla.org/listinfo/dev-servo >>> >> >> > > > -- > > Thanks & Regards > Ravi Patel > 919-931-6725 > _______________________________________________ dev-servo mailing list [email protected] https://lists.mozilla.org/listinfo/dev-servo
