Stepping in to first say: This is fantastic work, willkg! Next: :asuth, do you think there'd be benefits to having similar context-menu options for Glean metrics? Like on `build_displaylist_time`[1] we could point to the Glean Dictionary entry for it[2] and/or GLAM[3]?
:chutten [1]: https://searchfox.org/mozilla-central/source/layout/base/nsLayoutUtils.cpp#3108 [2]: https://dictionary.telemetry.mozilla.org/apps/firefox_desktop/metrics/paint_build_displaylist_time [3]: https://glam.telemetry.mozilla.org/fog/probe/paint_build_displaylist_time/explore?aggType=avg¤tPage=1&ping_type=* On Thu, Dec 1, 2022 at 8:28 PM Andrew Sutherland < asutherl...@asutherland.org> wrote: > This is super amazing! It's invaluable to know the space of annotation > data that is available, and in particular, I love the example data from > the last 7 days. Thank you! > > Is the example data something that could potentially be fetched in an > aggregate JSON so that searchfox could provide the example data in > "inlay hint" style (ex: what VS Code does for inferred types for rust > analyzer and clangd) in source listings where the > `CrashReporter::Annotation::*` symbols are found in the source? (This > would be an optional display thing, and for this specific case maybe it > would be more likely to end up in a forthcoming sidebar.) > > For example, I see there's a call to CrashReport::AnnotateCrashReport at > > https://searchfox.org/mozilla-central/rev/2fc2ccf960c2f7c419262ac7215715c5235948db/ipc/glue/ProtocolUtils.cpp#76-88 > with the `CrashReporter::Annotation::IPCSystemError` symbol used, and we > could hang the example data off that symbol if there's a JSON dictionary > that has the `IPCSystemError` name from > > https://crash-stats.mozilla.org/documentation/datadictionary/dataset/annotation/field/IPCSystemError > that we can mangle using a mozilla-central specific config file. Right > now I do see the example data is in > > https://crash-stats.mozilla.org/documentation/datadictionary/dataset/processed/field/ipc_system_error > which links to the former, but ideally the information would be directly > coupled or available elsewhere in the JSON object so that searchfox > could do a straighforward lookup in either direction. > > Searchfox could also add one or more context-menu options like "Go to > crash stats docs for IPCSystemError" or "Search crash stats for > IPCSystemError" or things like that on the symbol, although that's > separable from having JSON dictionary as long as there's a predictable > URL scheme searchfox can use from the symbol name[1]. > > Andrew > > 1: Disclaimer: The context-menu functionality is still in progress, but > I'm confident about being able to get to that functionality over my > holiday break as it's essential to complete the first round of automatic > diagramming so it can be exposed to users. > > > -- > You received this message because you are subscribed to the Google Groups " > dev-platform@mozilla.org" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to dev-platform+unsubscr...@mozilla.org. > To view this discussion on the web visit > https://groups.google.com/a/mozilla.org/d/msgid/dev-platform/0956e3ff-286e-f8b7-9f8e-1ca57f54838c%40asutherland.org > . > -- You received this message because you are subscribed to the Google Groups "dev-platform@mozilla.org" group. To unsubscribe from this group and stop receiving emails from it, send an email to dev-platform+unsubscr...@mozilla.org. To view this discussion on the web visit https://groups.google.com/a/mozilla.org/d/msgid/dev-platform/CAMPhgK-h8y7LvHsykXYL164FdU1may7iYNP0q5abtYcP20Ji1A%40mail.gmail.com.
