On 1/7/2021 4:18 AM, Sebastian Zartner wrote:
On Wednesday, January 6, 2021 at 10:55:22 PM UTC+1, Doug Thayer wrote:
On 1/6/2021 1:51 PM, Mike Hommey wrote:
On Wed, Jan 06, 2021 at 01:46:52PM -0800, Doug Thayer wrote:
On 1/6/2021 1:44 PM, Mike Hommey wrote:
On Wed, Jan 06, 2021 at 01:30:00PM -0800, Doug Thayer wrote:
On Wed, Jan 6, 2021 at 1:23 PM Mike Hommey <m...@glandium.org> wrote:
On Wed, Jan 06, 2021 at 11:57:18AM -0800, Doug Thayer wrote:
If you don't spend any time on Nightly in Windows 10, please feel free to
disregard this.
tl;dr: we're sometimes creating the first window differently than usual,
so
be on the lookout for breakages.
On 2021-01-05, a change landed in Nightly which enabled the pre-XUL
skeleton
UI [1]. This is a feature which allows us to create the first window and
populate it with a non-interactive placeholder UI before we load
xul.dll. On
some systems, this can mean we can give visual indication of Firefox
launching as much as 15 seconds sooner than normal (loading xul.dll can
take
a while). We're hoping this could be a big win for users who experience
very
slow startups, and we also hope it will improve the overall snappiness of
startup even on fast systems.
What does the placeholder UI look like?
Colors and layout can vary, but the basic look is this:
[image: image.png]
The image attachment didn't quite work.
Woops. Here is a link: https://i.imgur.com/R4ynXW5.png
Does the placement and the size of that window vary?
It does. It uses values persisted to the registry based on the most
recent run of the default profile, scoped by the path to the executable.
The registry values can be found at
HKEY_CURRENT_USER\SOFTWARE\Mozilla\Firefox\PreXULSkeletonUISettings.
I am running Nightly 86.0a1 (2021-01-07) 64bit on Windows 10 on a freshly
created profile and checked that the browser.startup.preXulSkeletonUI
preference is set to true, though instead of seeing the UI I get a blank white
window. I remember, I tested this feature like a month or two ago and it did
work before. Is that expected? If not, please let me know what information is
needed to track this down and I'll file a bug for it.
It could be expected. It's probably worth having some kind of disabled
reason listed somewhere at some point. For the time being, I'll
enumerate a few ways that this could get automatically disabled:
1) You could be running firefox.exe with command line arguments. We have
a finite list of command line arguments which are approved - if we see
anything outside that list we disable the skeleton UI. This covers, for
example, launching the profile manager, which is of course a window that
looks nothing like the typical main browser window. The list of approved
command line arguments is defined in code here:
https://searchfox.org/mozilla-central/rev/519f913527b0d9d5097d290d5731cff6b2991fe0/mozglue/misc/PreXULSkeletonUI.cpp#1570
2) You could be running with a theme other than the built-in dark,
light, and default themes. I suspect this is not true because you said
you're on a fresh profile. There are also a handful of other prefs which
will disable the skeleton UI if they're not the value we expect, but
again since you're on a fresh profile those should all be fine.
3) You could be running with any of these environment variables:
https://searchfox.org/mozilla-central/rev/519f913527b0d9d5097d290d5731cff6b2991fe0/mozglue/misc/PreXULSkeletonUI.cpp#1690
4) You could already be running an instance of firefox with the same path.
5) You could have configured firefox to always open the profile manager.
If it's outside those, then I think it's worth filing a bug or following
up with me outside of the list?
|
|||
Also, regarding the registry values, I only see one for the theme with a key
referring to the path of the Nightly executable. How will you handle different
profiles?
I hinted at this above in this message, but effectively we only allow
the skeleton UI if we are running the default profile. So if you have
firefox set up to always start the profile manager, or you specify a
profile via the command line or an environment variable, then we simply
bail out and don't show anything.
Besides those issues, I'm really happy to see this coming. It improves
perceived start up speed a lot, especially on less powerful machines.
Sebastian
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
