The error levels are displayed at the top of a revision, in the Diff detail
> Lint section. You'll see a list of issues there, the first column
indicates their Severity.

Good point about replying to lint issues, I don't think Phabricator allows
developers to do that, as lint issues are transient.

Bastien Abadie

On Sat, Mar 28, 2020 at 2:20 AM Gerald Squelart <gsquel...@mozilla.com>
wrote:

> On Friday, March 27, 2020 at 11:11:46 PM UTC+11, Bastien Abadie wrote:
> > The code review bot has been updated today and now publishes all issues
> > found on your patches as Phabricator lint results (Diff Detail section)
> > instead of inline comments.
> >
> > Here is a sample revision showcasing the new style.
> > <https://phabricator-dev.allizom.org/D1758> (on phabricator staging)
> >
> >
> > The main difference for developers is that lint results are tied to a
> > specific patch; so when you update your revision, the lint results are
> > automatically removed and only new ones are displayed (if any).
> >
> > Please be aware that any Error found by the bot must be fixed before
> > landing, or your patch will break the CI. Warnings can still be ignored
> and
> > should not break the build.
> >
> > The summary comment remains the same, and will always appear in the
> > revision to keep track of the revision evolution.
> >
> > Thanks a lot to all the developers
> > <https://bugzilla.mozilla.org/show_bug.cgi?id=1608339> who suggested
> this
> > styling change, we hope you’ll enjoy this enhancement.
> >
> > If you have any questions regarding this change or the code review bot,
> you
> > can reach us on Matrix #code-review-bot
> > <https://chat.mozilla.org/#/room/#code-review-bot:mozilla.org>.
> >
> >
> > Bastien Abadie
>
> It looks nice, thank you! Not seeing expired issues will be great.
>
> > ... Error must be fixed ... Warnings can be ignored ...
>
> Reviewbot used to prefix messages with "Warning" or "Error", but I don't
> see it in Lint messages. How can we make the distinction?
>
> Also Reviewbot comments could be replied to, but I don't see a way to do
> that with Lint messages, is that intended?
>
> Cheers,
> Gerald
> _______________________________________________
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to