Hey Marco,
The whitespace changes are expected; there are no other parts which await
landing.
Readability might be better or similar as before, depending on the original
code. And having more consistency and predictability, not just within teams but
within Mozilla, is a good thing. This reduces time spent talking about and
adjusting whitespace when writing, reviewing, and discussing code.
Tweaking "code quality" rules in Eslint continues as before (assuming they
don’t interfere with Prettier), and this could affect the final output; it is
still up to Prettier to enforce this consistency.
Victor
> On 7. Jul 2019, at 23:36, Marco Bonardo <mbona...@mozilla.com> wrote:
>
> Hi,
> the new style in some cases doesn't look more readable than before, and some
> files grew a lot vertically due to huge amount of added newlines.
> For example:
> Assert.equal(newPrincipalURI, originalPrincipalURI,
> "content has the same principal");
> now has to be written as:
> Assert.equal(
> newPrincipalURI,
> originalPrincipalURI,
> "content has the same principal"
> );
>
> Multi-condition ifs:
> if (cond1 &&
> cond2 &&
> cond3) {
> now are
> if (
> cond1 &&
> cond2 &&
> cond3
> ) {
>
> Also assignments
> let revHost = host.split("")
> .reverse()
> .join("") + ".";
> now are
> let revHost =
> host
> .split("")
> .reverse()
> .join("") + ".";
>
> Are all of these expected, or are there parts that should land yet?
>
> Cheers,
> Marco
>
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
