Prettier will share eslint's list of things to ignore and those tests are already ignored: https://searchfox.org/mozilla-central/rev/1133b6716d9a8131c09754f3f29288484896b8b6/.eslintignore#239 .
Of course if you want parts of that directory to be linted and formatted then you can modify that file as necessary. On Thu, Jun 13, 2019 at 1:21 PM Jason Orendorff <jorendo...@mozilla.com> wrote: > On Thu, Jun 13, 2019 at 1:42 PM Victor Porof <vpo...@mozilla.com> wrote: > > > To improve developer productivity, we plan to automate JS formatting > using > > Prettier <https://prettier.io/>, a broadly adopted tool specifically > > designed for this task and maintained by well known stakeholders. This > > should reduce the amount of time spent writing and reviewing JS code. > > > > Thanks for doing this! > > This could cause some JS engine frontend tests (under js/src/tests/non262 > and js/src/jit-test) to silently stop testing what they're meant to test. > For example, Prettier inserts missing semicolons (which is GREAT) but we > want to keep our Automatic Semicolon Insertion test coverage. > > What should we do? The number of test files affected is probably a very > small fraction of the whole, but they're important (try implementing ASI > sometime) and I don't know how to identify them. It's not obvious from the > filenames. Some directory names (non262/{jit,JSON,Map}) imply that it's > probably fine to beautify everything in there, but a lot of files are named > stuff like "tests/non262/extensions/regress-474771-01.js". > > -j > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
