> On Apr 1, 2019, at 12:38 PM, Brian Grinstead <bgrinst...@mozilla.com> wrote:
>>> Links to bugs/comments/etc can be added in the test if they are relevant, 
>>> but I don't know that it's important enough to add another step in front of 
>>> getting a useful test case built. I did also consider adding a TODO comment 
>>> in the template to add a bug link (though in a single place instead of 4), 
>>> but not to require that information up front.
>> 
>> I think realistically getting to the bug through the version control history 
>> is reasonable, so there's not that much reason to have a bug link in the 
>> test itself.
>> 
>> I would further argue that the <title> in just about all our mochitests is 
>> pointless and could go from the template.
> 
> Would be happy to remove that - I was wondering why it was useful when I 
> started changing the templates and couldn’t think of a great reason.

I realize now that <title> is used to display a summary of the test from 
searchfox listing, so perhaps we shouldn't remove it. For example: 
https://searchfox.org/mozilla-central/rev/201450283cddc9e409cec707acb65ba6cf6037b1/accessible/tests/mochitest/test_descr.html#4
 sets the title as "nsIAccessible::description tests”, which can also be seen 
in the directory listing at 
https://searchfox.org/mozilla-central/source/accessible/tests/mochitest.

Brian

_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to