I think Johann is right. Thanks for the design, Eric, this looks great to me. I think reloading all tabs is a much better idea than restarting the browser. I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1526075 for this.
On Mon, Feb 4, 2019 at 8:16 AM Johann Hofmann <jhofm...@mozilla.com> wrote: > In my experience having to restart applications to make settings apply is > the worst thing ever, hence I really like your mock. We should make sure to > include it in the bug (or a follow-up) for this proposed change. > > On Thu, Jan 31, 2019 at 8:13 PM <ep...@mozilla.com> wrote: > > > On Monday, January 28, 2019 at 11:08:32 AM UTC-5, Ehsan Akhgari wrote: > > > On Mon, Jan 28, 2019 at 10:51 AM Daniel Veditz <dved...@mozilla.com> > > wrote: > > > > > > > On Mon, Jan 28, 2019 at 12:57 AM Andrea Marchesini < > > > > amarches...@mozilla.com> wrote: > > > > > > > >> If we try to apply the new cookie policy immediately, 3rd party > > trackers > > > >> in opened tabs should switch to a first-party-isolation storage, but > > they > > > >> could also have already data in memory (user-tokens), and populate > > the new > > > >> cookie jar consequentially. This would break the isolation. The > > solution in > > > >> this case, is to apply the change only after the reloading. > > > >> > > > > > > > > That's a great point in favor of your proposal. I'm still concerned > > about > > > > "infinite-page" sites (facebook/twitter/etc) where a user typically > > rarely > > > > reloads. Would it be too ugly to apply an infobar to each active tab > > that > > > > says "The cookie policy has changed. Reload to apply the new policy > > > > [Reload]"? Or maybe has a [Reload this tab][Reload All] set of > > buttons. I > > > > have serious misgivings about my UX suggestion here, but maybe it > will > > > > spark better ideas on how to communicate to users. An > alert/doorhanger > > in > > > > the pref page where the setting is changed that warns the user it > only > > > > applies to new pages and offers to reload all active tabs? > > > > > > > > > > One option that we have for handling this change is to modify the way > we > > > apply the change in the Preferences UI instead of asking people to > reload > > > their pages. For example, we can ask the user to restart their browser > > > when they make changes to the cookie policy/permissions (similar to how > > > turning permanent private browsing on/off works), or add a notice in > the > > > Preferences saying that the changes made will only affect pages loaded > > from > > > now on, etc. > > > > > > I don't think showing a message on every open tab to ask the user to > > reload > > > it is the only UX that is possible for solving this problem, it's only > > one > > > rough idea (AFAIK nobody has talked to the UX team about it yet!)... > > > > > > Cheers, > > > -- > > > Ehsan > > > > > > From a UX perspective I think your proposal makes sense, Baku. > > > > I feel that having a user manually reload each individual tab they have > > open is too much to ask. > > > > I spoke with Bryan Bell and we share Ehsan thinking. > > If a user changes preferences that affect the cookie policy they get an > > extra box that appears and explains they need to reload tabs in order for > > the new policy to apply. > > > > Did a quick mock up to show what this might look like (note the mock > isn't > > final and the copy hasn't been reviewed) > > > > Mock can be found here: https://cl.ly/7b6cc1e85e36 > > > > Also, instead of reloading the tabs we can restart their browser as Ehsan > > mentioned. We'll just have to be careful and explain that all their tabs > > will be reopened. Is one way more performant than the other? > > > > Regards, > > Eric > > _______________________________________________ > > dev-platform mailing list > > dev-platform@lists.mozilla.org > > https://lists.mozilla.org/listinfo/dev-platform > > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > -- Ehsan _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
