On Mon, Jan 14, 2019 at 9:12 AM Bobby Holley <bobbyhol...@gmail.com> wrote:

>
> I think the answer is "it depends". BasePrincipal makes a lot of sense for
> principals, because it allows for a lot of sharing among the subclasses, of
> which there are only four. URIs are more complicated, and probably deserve
> a dedicated conversation.
>
> So I think that a shared C++ superclass is a useful and ergonomic pattern.
> That's not quite the same as "we should switch to this pattern everywhere",
> because the tradeoffs vary.
>

Got it, that's what I was expecting, just wanted to make sure.


> And we need to weigh the benefit of any cleanup-related engineering work
> against other priorities.
>

This wasn't a proposal for anyone to work on anything as a dedicated
project, just making sure that some of the patterns I was seeing warranted
some tracking for cleanup at some point. I'm bouncing around a lot of the
code base right now and can at least file for later work.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to