I should say that the shippable build proposal ( https://groups.google.com/d/msg/mozilla.dev.planning/JomJmzGOGMY/vytPViZBDgAJ) doesn't seem to intersect negatively with this.
And in fact I think these two proposals compliment each other quite nicely. Additionally I have no concerns over this work taking place prior to my work being complete. on the specific proposal front I can envision us allowing tests to be run on non-pgo builds via triggers (so never by default, but always backfillable/selectable) should someone need to try and bisect an issue that is discovered... I'm not sure if the code maintenance burden is worth it for the benefit but I don't hold a strong opinion there. ~Justin Wood (Callek) On Thu, Jan 3, 2019 at 11:44 AM Andrew Halberstadt <a...@mozilla.com> wrote: > CC Callek > > How will this interact with the "shippable builds" project that Callek > posted > about awhile back? My understanding is there's a high probability PGO is > going away. Would it make sense to wait for that to project to wrap up? > > -Andrew > > On Thu, Jan 3, 2019 at 11:20 AM jmaher <joel.ma...@gmail.com> wrote: > >> I would like to propose that we do not run tests on linux64-opt, >> windows7-opt, and windows10-opt. >> >> Why am I proposing this: >> 1) All test regressions that were found on trunk are mostly on debug, and >> in fewer cases on PGO. There are no unique regressions found in the last 6 >> months (all the data I looked at) that are exclusive to OPT builds. >> 2) On mozilla-beta, mozilla-release, and ESR, we only build/test PGO >> builds, we do not run tests on plan OPT builds >> 3) This will reduce the jobs (about 16%) we run which in turn reduces, >> cpu time, money spent, turnaround time, intermittents, complexity of the >> taskgraph. >> 4) PGO builds are very similar to OPT builds, but we add flags to >> generate profile data and small adjustments to build scripts behind MOZ_PGO >> flag in-tree, then we launch the browser, collect data, and repack our >> binaries for faster performance. >> 5) We ship PGO builds, not OPT builds >> >> What are the risks associated with this? >> 1) try server build times will increase as we will be testing on PGO >> instead of OPT >> 2) we could miss a regression that only shows up on OPT, but if we only >> ship PGO and once we leave central we do not build OPT, this is a very low >> risk. >> >> I would like to hear any concerns you might have on this or other areas >> which I have overlooked. Assuming there are no risks which block this, I >> would like to have a decision by January 11th, and make the adjustments on >> January 28th when Firefox 67 is on trunk. >> _______________________________________________ >> dev-platform mailing list >> dev-platform@lists.mozilla.org >> https://lists.mozilla.org/listinfo/dev-platform >> > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
