On Fri, Nov 30, 2018 at 1:00 PM <tcampb...@mozilla.com> wrote: > Now that all of mozilla-central is been migrated to use clang-format > automated code formatting, the question of what should happen with editor > modelines at the top of files should be considered. > > https://bugzilla.mozilla.org/show_bug.cgi?id=clang-format > > Here are some options and some arguments I've heard. Please reply with > further ideas or rationale. I've not classified points as pro/con and leave > that up to the reader's interpretation. > > Option 1: Remove mode lines > - Devs are expected to run clang-format anyways (hopefully automated > with a hook of sorts) >
Hopefully with the editor integrations that are available ( https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style/Formatting_C++_Code_With_clang-format#Editor_Integrations). But this would still not give consistent result while typing in all editors, and this may bother the users of those editors. The text line width setting especially seems important here. > - Devs are free to set their modeline configuration elsewhere > - If they aren't providing value, they deserve to be removed. > - Many of these were already inconsistent/wrong, so this might be an > opportunity to phase out > FWIW after a cursory conversation with kmag on IRC the other day, we realized that it seems that Vim modelines tend to be largely consistent, whereas the same doesn't seem to be the case for Emacs modelines. So the experience of individual developers probably depends on editor choice here. > - Not all devs use vim/emacs, so we should think about workflows help > that doesn't need stuff in every single source file. > - The editorconfig project (https://editorconfig.org/) aims to solve > this for a variety of editors without marking each file > > Option 2: Fix mode lines > - A correct text-width mode-line gives a closer first approximation for > devs > - Certain files (eg. moz.build, obj-C headers) use a non-standard file > types. > > A hybrid of these is also very possible, such as removing certain > attributes or only using when file type is non-standard. > > I had originally intended this discussion for js/ components, but it turns > out to be a question across the whole tree (even if the solution chosen is > per-module). > I think these are all great points. It seems like for Emacs, it is not actually necessary to sprinkle modelines across all of the files in your repository (per https://bugzilla.mozilla.org/show_bug.cgi?id=1023839#c7). For Vim, Benjamin Bouvier just landed a patch in https://bugzilla.mozilla.org/show_bug.cgi?id=1511383 to update the existing modelines to have proper line width and tab width. It seems like for Emacs, we should probably do something similar also relatively soon merely to address the newly introduced inconsistencies due to the reformat. But I'd like to hear from Emacs users what they think, and if they have a preference on updating existing modelines vs using a .dir-locals.el file instead... And of course, further improvements, such as supporting the editorconfig format is also interesting to discuss, so users of other editors, please do share feedback! Thanks, -- Ehsan _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
