TL;DR When asking for review to multiple reviewers, and all of them must accept your revision, you must mark them as blocking reviews, either in the Phabricator ui or appending "!" at the end of the reviewer name. Otherwise it's first-come-first-serve.
Full details: Standard8 asked for review to both me and Lina, as we were used to do in splinter and mozreview. Lina accepted the revision, and that was enough to approve it. At the same time the review request to me disappeared from both the Bugzilla and the Phabricator dashboards. I totally forgot about it until today, when speaking about the bug on IRC I remembered that some days ago I had got a notification about this review, but I never did it. The revision in Phabricator is marked as Accepted and Waiting on Author, even if my review is still pending, it would go through Lando without any problem. I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1472689 where Glob suggested to use blocking-reviews instead. Standard8 changed the review request to blocking from the Edit Revisions / Reviewers field, and it properly re-appeared in my dashboards. I just wanted to warn you about this different behavior, since we're not used to it, I found it quite surprising and risked to miss this request completely for days. Cheers, Marco _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
