On Tue, Apr 10, 2018 at 02:46:40PM +1000, Martin Thomson wrote: > This seems like a good idea. > > Please consider adding hg.mozilla.org to your list of things you will > clone from. That will allow us to remove some ugly hacks from the > tree for vendoring NSS and NSPR. (libffi uses the same script, but it > seems to be on GitHub now, so that seems like an easy win assuming > even that libffi still uses that script.) We could use the NSS GitHub > mirror, but NSPR doesn't have one yet and those can't be the only > projects that we have using mercurial. Of course, if that is the > case, then don't worry, we'll just have to talk more seriously about > moving NSS to GitHub. > > You don't permit the use of a tag for vendoring, is that intentional? > Tags for releases are so commonplace that you should consider it. You > shouldn't need a branch AND a tag either. More so because branches > move, which makes them not reliable here. > > Having a version in addition to a tag is redundant and therefore > likely to result in mismatches. I'd say that the tag is enough.
I'd say a revision should be mandatory. Branches and tags can change. Revisions can't. Mike _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
