On Fri, Dec 1, 2017 at 3:15 AM, Makoto Kato <m_k...@ga2.so-net.ne.jp> wrote: > I think that we don't have any data when user doesn't use non-UTF-8 > (and C) locale such as ja_JP.eucJP. We should get data via telemetry.
What should the telemetry measure? (Measuring whether we compute paths to be UTF-8 in the code that still supports non-UTF-8 configurations would probably be the wrong thing to measure, because the "C" locale doesn't compute to UTF-8 and no one has cared enough to fix that.) What kind of telemetry data would we need to see in order to proceed with https://bugzilla.mozilla.org/show_bug.cgi?id=960957 (removing the remains of support for non-UTF-8 file paths)? And if we didn't proceed with that course of action, what would the alternative course of action be? The current state doesn't really support non-UTF-8 file paths. https://bugzilla.mozilla.org/show_bug.cgi?id=1342659 has been open for 9 months, and the user was upgrading from Firefox 17 to 50 in order to notice the problem, so the bug has been there for more than 9 months before the complaint. https://bugzilla.mozilla.org/show_bug.cgi?id=848268 has been open for 5 years. It looks like no one cares enough about non-UTF-8 configurations to make Gecko do what arguably would be the right way to support non-UTF-8 file paths: using the glib file path conversion functions, which don't do non-UTF-8 things unless the G_BROKEN_FILENAMES environment variable has been set. The name of the environment variable is very telling. Considering that we mainly get Gtk telemetry from Ubuntu which has had UTF-8 paths since its introduction and our support for non-UTF-8 file paths has been broken for years without much complaint (AFAIK 3 users reporting non-UTF-8: two EUC-JP and one ISO-8859-something in the past 5 years), can we really expect telemetry to tell us anything useful? Non-UTF-8 paths are an even more deeply legacy configuration than non-PulseAudio audio, and telemetry told us was OK to go PulseAudio-only. Four years ago, smontagu said that in the last 5 years (i.e. since nine years ago now), the code he had contributed assumed UTF-8 on *nix: https://www.mail-archive.com/dev-platform@lists.mozilla.org/msg06083.html I suggest that instead of delaying with a round of telemetry, we make all non-Windows platforms in nsNativeCharsetUtils.cpp use what's currently the OSX/Android code path. -- Henri Sivonen hsivo...@hsivonen.fi https://hsivonen.fi/ _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
