On 23/11/2017 12:05, Jeff Gilbert wrote:
I agree that MakeNotNull doesn't sound like it allocates. Reads to me as Make[Into]NotNull. Context will *usually* make this clear, but why not NewNotNull? (Honestly I don't like MakeUnique to begin with)
As far as naming is concerned, ISTM that "Create..." would be clearer than "Make..." for methods like this, as it's not so easy to misinterpret as "make [an existing thing] into [a certain state]".
JK _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
