On Fri, Sep 8, 2017 at 1:08 AM, Ehsan Akhgari <ehsan.akhg...@gmail.com> wrote:
> The great majority of code changing is quite expected for any project
> switching to clang-format, since as it turns out automated tools are much
> better at doing this grunt work than humans are. The reason projects choose
> to switch to using clang-format is increasing developer productivity by
> allowing editor/IDE integration for formatting the code as you're editing
> it, ensuring the code formatting remains consistent over time without
> needing to spend invaluable engineering time on it, and being able to stop
> debating whitespace issues and moving on to focus on more productive
> discussions. ;-)
I am 100% behind this idea. NSS is already there and it's so nice.
One question, because it hurts me every day now, which version of
clang-format will we use? NSS actually has checks in CI that will
fail if you submit unformatted code (it gives you a nice patch you can
download and apply to fix the problem even), so we're very particular
about this. However, my local version of clang-format is more recent.
There are small differences in its handling of certain constructs.
It's been screwing up my pre-commit hook for a while now (I just
haven't gotten around to fixing it just yet).
e.g.,
3.9
- CheckAcks(client_filters_, 0, {0, // SH
- 0x0002000000000000ULL, // EE
- 0x0002000000000002ULL} // CT2
4.0
+ CheckAcks(client_filters_, 0,
+ {0, // SH
+ 0x0002000000000000ULL, // EE
+ 0x0002000000000002ULL} // CT2
Have we had the version discussion yet?
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
