I think we disable it for local builds because we don't control what versions of tools folks use. So clang vFOO might spit out errors we don't see in clang vBAR and it would be a huge pain if those failed locally even though they'd be fine in automation.
-e On Thu, May 25, 2017 at 4:07 PM, Andrew McCreight <amccrei...@mozilla.com> wrote: > On Thu, May 25, 2017 at 4:03 PM, <gsquel...@mozilla.com> wrote: > > > On Friday, May 26, 2017 at 6:03:02 AM UTC+12, Chris Peterson wrote: > > > On 2017-05-25 5:31 AM, Ehsan Akhgari wrote: > > > > On 05/19/2017 02:44 PM, Gregory Szorc wrote: > > > >> `mach build` attempts to parse compiler warnings to a persisted > > > >> "database." > > > >> You can view a list of compiler warnings post build by running `mach > > > >> warnings-list`. The intent behind this feature was to make it easier > > to > > > >> find and fix compiler warnings. After all, something out of sight is > > > >> out of > > > >> mind. > > > > > > Given that we treat warnings as errors on CI and most directories that > > > opt out of warnings-as-errors are third-party code > > > (ALLOW_COMPILER_WARNINGS in moz.build [1]), I don't think we need to > > > make the warning list any more visible. A warning regression in nearly > > > all first-party code is already treated as an error. > > > > > > > > > [1] > > > https://searchfox.org/mozilla-central/search?q=ALLOW_ > > COMPILER_WARNINGS&case=true&path=moz.build > > > > Tangentially: "we treat warnings as errors on CI" -- It'd be great if > > local builds could have that behavior by default, so we (or just I?) > don't > > get caught by surprise when warnings-as-errors appear after landing. > > > > Or at least: Can I opt-in locally? (I tried 'ac_add_options > > --enable-warnings-ar-errors' in mozconfig, but that was not recognized.) > > > > This has worked for me before: > ac_add_options --enable-warnings-as-errors > > > _______________________________________________ > > dev-platform mailing list > > dev-platform@lists.mozilla.org > > https://lists.mozilla.org/listinfo/dev-platform > > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
